Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 12212030: Re-implement IsolateFileUtil tests on top of new cross-fs operation architecture (Closed)

Created:
7 years, 10 months ago by kinuko
Modified:
7 years, 10 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Re-implement IsolateFileUtil tests on top of new cross-fs operation architecture Deprecate FileUtilHelper::{Copy,Move} and recursive file enumerator in favor of AsyncFileTestHelper::{Copy,Move,ReadDirectory} BUG=146215, 174576 TEST=IsolatedFileUtilTest.CopyOut* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182455

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -138 lines) Patch
M webkit/fileapi/isolated_file_util_unittest.cc View 1 13 chunks +157 lines, -138 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinuko
Can you review? Another cleanup patch for the cross-filesystem operation change.
7 years, 10 months ago (2013-02-13 12:07:24 UTC) #1
tzik
lgtm https://codereview.chromium.org/12212030/diff/1/webkit/fileapi/isolated_file_util_unittest.cc File webkit/fileapi/isolated_file_util_unittest.cc (right): https://codereview.chromium.org/12212030/diff/1/webkit/fileapi/isolated_file_util_unittest.cc#newcode78 webkit/fileapi/isolated_file_util_unittest.cc:78: root.virtual_path().AppendRelativePath(url.virtual_path(), &relative); could you check the return value ...
7 years, 10 months ago (2013-02-13 13:18:48 UTC) #2
nhiroki
lgtm
7 years, 10 months ago (2013-02-14 02:18:41 UTC) #3
kinuko
Thanks, updated. https://codereview.chromium.org/12212030/diff/1/webkit/fileapi/isolated_file_util_unittest.cc File webkit/fileapi/isolated_file_util_unittest.cc (right): https://codereview.chromium.org/12212030/diff/1/webkit/fileapi/isolated_file_util_unittest.cc#newcode78 webkit/fileapi/isolated_file_util_unittest.cc:78: root.virtual_path().AppendRelativePath(url.virtual_path(), &relative); On 2013/02/13 13:18:48, tzik wrote: ...
7 years, 10 months ago (2013-02-14 09:12:51 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-02-14 09:25:52 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698