chrome: Initial step into building the views UI of Chrome Browser as a component.

chrome: Initial step into building the views UI of Chrome Browser as a component.

BUG=125846
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182369

[tfarina, 2013-02-05 13:52:53]

Ben I want to start small, to reduce the chances of breaking something.

What you think?

https://codereview.chromium.org/12212013/diff/1/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/12212013/diff/1/chrome/chrome_browser_ui.gypi...
chrome/chrome_browser_ui.gypi:20:
'chrome_browser_ui_views.gypi:browser_ui_views',
My goal is, in future, browser_ui will not (should not) be allowed to depend on
browser_ui_views. But browser_ui_views can/will depend on browser_ui.

[tfarina, 2013-02-06 14:05:36]

friendly ping Ben?

[Ben Goodger (Google), 2013-02-06 17:34:06]

https://codereview.chromium.org/12212013/diff/2001/chrome/chrome_browser_ui_v...
File chrome/chrome_browser_ui_views.gyp (right):

https://codereview.chromium.org/12212013/diff/2001/chrome/chrome_browser_ui_v...
chrome/chrome_browser_ui_views.gyp:9: 'type': 'static_library',
is it possible to do this as <(component)?

[tfarina, 2013-02-06 17:36:44]

https://codereview.chromium.org/12212013/diff/2001/chrome/chrome_browser_ui_v...
File chrome/chrome_browser_ui_views.gyp (right):

https://codereview.chromium.org/12212013/diff/2001/chrome/chrome_browser_ui_v...
chrome/chrome_browser_ui_views.gyp:9: 'type': 'static_library',
On 2013/02/06 17:34:06, Ben Goodger (Google) wrote:
> is it possible to do this as <(component)?
Yes.

Would you be fine with:

CHROME_VIEWS_EXPORT/CHROME_VIEWS_IMPLEMENTATION and
chrome/browser/ui/views/chrome_views_export.h

?

[tfarina, 2013-02-07 00:28:49]

Hey Ben, your component is up. PTAL!

[tfarina, 2013-02-12 18:15:59]

Ping?

[Ben Goodger (Google), 2013-02-12 18:24:33]

https://codereview.chromium.org/12212013/diff/5002/chrome/chrome_browser_ui_v...
File chrome/chrome_browser_ui_views.gyp (right):

https://codereview.chromium.org/12212013/diff/5002/chrome/chrome_browser_ui_v...
chrome/chrome_browser_ui_views.gyp:10: 'variables': {
'enable_wexit_time_destructors': 1, },
what's this? is this necessary?

[tfarina, 2013-02-12 18:45:30]

PTAL.

https://codereview.chromium.org/12212013/diff/5002/chrome/chrome_browser_ui_v...
File chrome/chrome_browser_ui_views.gyp (right):

https://codereview.chromium.org/12212013/diff/5002/chrome/chrome_browser_ui_v...
chrome/chrome_browser_ui_views.gyp:10: 'variables': {
'enable_wexit_time_destructors': 1, },
On 2013/02/12 18:24:33, Ben Goodger (Google) wrote:
> what's this? is this necessary?
Nope. Removed.

[tfarina, 2013-02-13 18:48:23]

Ping?

[Ben Goodger (Google), 2013-02-13 22:22:03]

lgtm

[commit-bot: I haz the power, 2013-02-13 22:26:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12212013/4

[commit-bot: I haz the power, 2013-02-13 23:13:24]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, cacheinvalidation_unittests, check_deps, chromedriver2_unittests,
components_unittests, content_browsertests, content_unittests, crypto_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, nacl_integration, net_unittests, ppapi_unittests,
printing_unittests, remoting_unittests, sandbox_linux_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-02-14 01:18:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12212013/25001

[commit-bot: I haz the power, 2013-02-14 01:43:54]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, cacheinvalidation_unittests, check_deps, chromedriver2_unittests,
components_unittests, content_browsertests, content_unittests, crypto_unittests,
gpu_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, nacl_integration, net_unittests, ppapi_unittests,
printing_unittests, remoting_unittests, sandbox_linux_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[tfarina, 2013-02-14 02:04:33]

Landing this manually, as CQ is having its issues and not cooperating much.

[Nico, 2013-10-23 18:55:27]

https://codereview.chromium.org/12212013/diff/25001/chrome/chrome_browser_ui_...
File chrome/chrome_browser_ui_views.gyp (right):

https://codereview.chromium.org/12212013/diff/25001/chrome/chrome_browser_ui_...
chrome/chrome_browser_ui_views.gyp:5: {
This needs 

+  'variables': {
+    'chromium_code': 1,
+  },

else it builds with warnings disabled.

[tfarina, 2013-10-23 23:05:33]

https://codereview.chromium.org/12212013/diff/25001/chrome/chrome_browser_ui_...
File chrome/chrome_browser_ui_views.gyp (right):

https://codereview.chromium.org/12212013/diff/25001/chrome/chrome_browser_ui_...
chrome/chrome_browser_ui_views.gyp:5: {
On 2013/10/23 18:55:27, Nico wrote:
> This needs 
> 
> +  'variables': {
> +    'chromium_code': 1,
> +  },
> 
> else it builds with warnings disabled.

I'll add this.

Thanks Nico!