Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 12212011: Make __proto__ a foreign callback on Object.prototype. (Closed)

Created:
7 years, 10 months ago by Michael Starzinger
Modified:
7 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Make __proto__ a foreign callback on Object.prototype. This moves the __proto__ property to Object.prototype and turns it into a callback property actually present in the descriptor array as opposed to a hack in the properties lookup. For now it still is a "magic" data property using foreign callbacks and not an accessor property visible to JavaScript. The second effect of this change is that JSON.parse() no longer treats the __proto__ property specially, it will be defined as any other data property. Note that object literals still have their special handling. R=rossberg@chromium.org BUG=v8:621, v8:1949, v8:2441 TEST=mjsunit,cctest,test262 Committed: http://code.google.com/p/v8/source/detail?r=13728

Patch Set 1 #

Patch Set 2 : Remove commented code. #

Patch Set 3 : Added regression test for issue 2441. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -65 lines) Patch
M src/bootstrapper.cc View 1 chunk +19 lines, -3 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/json-parser.h View 2 chunks +5 lines, -11 lines 0 comments Download
M src/objects.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/property.h View 3 chunks +2 lines, -16 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/builtins.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/object-observe.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/proxies.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/json.js View 1 chunk +17 lines, -10 lines 0 comments Download
A + test/mjsunit/regress/regress-2441.js View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 10 months ago (2013-02-05 11:28:32 UTC) #1
rossberg
lgtm
7 years, 10 months ago (2013-02-05 12:15:12 UTC) #2
Michael Starzinger
7 years, 10 months ago (2013-02-26 10:46:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r13728 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698