Truncate the download file name if it exceeds the filesystem limit.

base/sys_info_posix.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sys_info.h"
 
 #include <errno.h>
 #include <string.h>
 #include <sys/param.h>
 #include <sys/utsname.h>
@@ skipping 32 matching lines @@
 int64 SysInfo::AmountOfFreeDiskSpace(const FilePath& path) {
   base::ThreadRestrictions::AssertIOAllowed();
 
   struct statvfs stats;
   if (statvfs(path.value().c_str(), &stats) != 0) {
     return -1;
   }
   return static_cast<int64>(stats.f_bavail) * stats.f_frsize;
 }
 
+// static
+int SysInfo::GetMaximumPathComponentLength(const FilePath& path) {
+  base::ThreadRestrictions::AssertIOAllowed();
+  if (!path.IsAbsolute())

[Mark Mentovai, 2013/02/08 18:14:02]

I don’t think this is relevant to the API. Maximum path component length of a
relative path can still be meaningful.

[kinaba, 2013/02/12 05:51:29]

Done.

+    return -1;
+
+  struct statvfs stats;
+  if (statvfs(path.value().c_str(), &stats) != 0) {

[Mark Mentovai, 2013/02/08 18:14:02]

On Mac OS X, you need to use pathconf(…, _PC_NAME_MAX) instead of statvfs if
you’re interested in f_namemax. statvfs returns a constant value for NAME_MAX
without considering the actual filesystem.

On Linux, pathconf(…, _PC_NAME_MAX) calls statfs under the hood, so pathconf
should be safe to use everywhere.

[kinaba, 2013/02/12 05:51:29]

Thanks for catching it! That greatly simplifies the code. Done.

+    return -1;
+  }
+#if defined(OS_ANDROID)
+  // Android uses statfs instead of statvfs. The field name differs.

[Mark Mentovai, 2013/02/08 18:14:02]

If you’re sticking with statfs for any code…

Hide this detail by way of a #define up above where statvfs is defined as statfs
for Android?

#define f_namemax f_namelen

[kinaba, 2013/02/12 05:51:29]

Done (using pathconf).

+  return static_cast<int>(stats.f_namelen);
+#else
+  return static_cast<int>(stats.f_namemax);
+#endif
+}
+
 #if !defined(OS_MACOSX) && !defined(OS_ANDROID)
 // static
 std::string SysInfo::OperatingSystemName() {
   struct utsname info;
   if (uname(&info) < 0) {
     NOTREACHED();
     return "";
   }
   return std::string(info.sysname);
 }
@@ skipping 26 matching lines @@
   }
   return arch;
 }
 
 // static
 size_t SysInfo::VMAllocationGranularity() {
   return getpagesize();
 }
 
 }  // namespace base