Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1221193005: [Android] Fix VibrationProvider crash. (Closed)

Created:
5 years, 5 months ago by timvolodine
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix VibrationProvider crash. Make sure the java class is in the apk. BUG=507220 Committed: https://crrev.com/0cfb09586ffce0b51e31d7ca8719ddb88d309179 Cr-Commit-Position: refs/heads/master@{#338042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/content.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
timvolodine
5 years, 5 months ago (2015-07-07 16:28:07 UTC) #2
timvolodine
+ jochen@: for content.gyp
5 years, 5 months ago (2015-07-08 10:38:36 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-08 13:22:22 UTC) #5
jochen (gone - plz use gerrit)
On 2015/07/08 at 13:22:22, jochen wrote: > lgtm has the BUILD.gn the dependency as well?
5 years, 5 months ago (2015-07-08 13:22:36 UTC) #6
timvolodine
Thanks jochen, this patch rectifies the regression due to https://codereview.chromium.org/1127043006/. I am not aware of ...
5 years, 5 months ago (2015-07-09 13:48:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221193005/1
5 years, 5 months ago (2015-07-09 13:49:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 15:09:56 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 15:10:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cfb09586ffce0b51e31d7ca8719ddb88d309179
Cr-Commit-Position: refs/heads/master@{#338042}

Powered by Google App Engine
This is Rietveld 408576698