chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm - Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm

Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove dealloc override. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm ('K') | « chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm ('k') | chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm

index 0edcb6a60832735866136104fdd05ff429e1a976..16d550d3421910a729c9a340ce9189e090a5006a 100644

--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller_unittest.mm

@@ -298,9 +298,11 @@ class BrowserRemovedObserver : public chrome::BrowserListObserver {

// This can happen because the ToolbarController is retained by both the

// BrowserWindowController and -[ToolbarController view], the latter of which is

// autoreleased.

-// TODO(nhiroki): This is disabled due to http://crbug.com/506745.

-TEST_F(ToolbarControllerTest, DISABLED_ToolbarDestroyedAfterBrowser) {

+TEST_F(ToolbarControllerTest, ToolbarDestroyedAfterBrowser) {

BrowserRemovedObserver observer;

+ // This is normally called by BrowserWindowController, but since |bar_| is not

+ // owned by one, call it here.

+ [bar_ browserWillBeDestroyed];

CloseBrowserWindow();

observer.WaitUntilBrowserRemoved();

// |bar_| is released in TearDown().