chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h - Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h

Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove dealloc override. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm ('K') | « chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm ('k') | chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm » ('j') | chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h

diff --git a/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h b/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h

index ceb452a34bcf84d7990eed25a19e1c738a345d63..cd68587a090db6aab1e1aed1da0e2465d8f3c6fc 100644

--- a/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h

+++ b/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h

@@ -8,13 +8,6 @@

#import <Cocoa/Cocoa.h>

#include "base/mac/scoped_nsobject.h"

-#include "base/memory/scoped_ptr.h"

-class Browser;

-namespace content {

-class WebContents;

// OverlayableContentsController is an obsolete wrapper holding the view where a

// tab's WebContents is displayed. In the old Chrome Instant implementation it

@@ -31,7 +24,7 @@ class WebContents;

@property(readonly, nonatomic) NSView* activeContainer;

// Initialization.

-- (id)initWithBrowser:(Browser*)browser;

+- (id)init;

tapted 2015/07/06 07:26:18 this is now an override, so no need to redeclare

jackhou1 2015/07/07 03:27:27 Done.

@end