chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm - Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

diff --git a/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm b/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

index 50b743ac9eeb3c5079b361d1f904ff9dc379b858..d3bf3a71d2f5c192403e18e1ee73968244660db9 100644

--- a/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

+++ b/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

@@ -4,11 +4,9 @@

#import "chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h"

-#include "content/public/browser/web_contents.h"

@implementation OverlayableContentsController

-- (id)initWithBrowser:(Browser*)browser {

+- (id)init {

if ((self = [super init])) {

base::scoped_nsobject<NSView> view(

[[NSView alloc] initWithFrame:NSZeroRect]);