Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: chrome/browser/ui/cocoa/download/download_shelf_controller.h

Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/download/download_shelf_controller.h
diff --git a/chrome/browser/ui/cocoa/download/download_shelf_controller.h b/chrome/browser/ui/cocoa/download/download_shelf_controller.h
index c264571b6f8b94217f042a1f89b43164b281ed6a..13e2a710371ff1d7d3f1bd80e752886c6c68b4b7 100644
--- a/chrome/browser/ui/cocoa/download/download_shelf_controller.h
+++ b/chrome/browser/ui/cocoa/download/download_shelf_controller.h
@@ -6,6 +6,7 @@
#include "base/mac/scoped_nsobject.h"
#include "base/memory/scoped_ptr.h"
+#import "chrome/browser/ui/cocoa/has_weak_browser_pointer.h"
#import "chrome/browser/ui/cocoa/view_resizer.h"
#include "ui/base/cocoa/tracking_area.h"
@@ -40,7 +41,8 @@ class PageNavigator;
// UI of an item itself is represented by a button that is drawn by
// download_item_cell.
-@interface DownloadShelfController : NSViewController<NSTextViewDelegate> {
+@interface DownloadShelfController
+ : NSViewController<NSTextViewDelegate, HasWeakBrowserPointer> {
@private
IBOutlet HoverButton* hoverCloseButton_;
@@ -120,10 +122,6 @@ class PageNavigator;
// Called by individual item controllers when their downloads are opened.
- (void)downloadWasOpened:(DownloadItemController*)download;
-// Notification that the download shelf is going to be destroyed and should
-// release the downloads.
-- (void)exiting;
-
// Return the height of the download shelf.
- (float)height;
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/download/download_shelf_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698