chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm - Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm

Issue 1221173003: [Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Keep -[BookmarBarController dealloc] instead of changing all the tests. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_controller.mm ('K') | « chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.h ('k') | chrome/browser/ui/cocoa/toolbar/toolbar_controller.h » ('j') | chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm

diff --git a/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm b/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm

index c7e2b0f3429e37553347bebc49bc6c3f343ae6f4..9011c814dcd38aed189b1aa538ec2c880336df4f 100644

--- a/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm

+++ b/chrome/browser/ui/cocoa/toolbar/back_forward_menu_controller.mm

@@ -40,6 +40,13 @@ using base::SysUTF16ToNSString;

return self;

}

+- (void)browserWillBeDestroyed {

+ [button_ setAttachedMenu:nil];

+ [backForwardMenu_ setDelegate:nil];

+ backForwardMenu_.reset();

+ model_.reset();

// Methods as delegate:

// Called by backForwardMenu_ just before tracking begins.