[Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"
 
 #import <QuartzCore/QuartzCore.h>
 
 #include <cmath>
 #include <limits>
@@ skipping 554 matching lines @@
     // constructed.
     if (existingTabCount) {
       [self performSelectorOnMainThread:@selector(layoutTabs)
                              withObject:nil
                           waitUntilDone:NO];
     }
   }
   return self;
 }
 
+- (void)browserWillBeDestroyed {
+  browser_ = nullptr;
+}
+
 - (void)dealloc {
   [tabStripView_ setController:nil];

[tapted, 2015/07/06 07:26:18]

Doing this for all the controlled views in other classes is probably a good idea
too...

[jackhou1, 2015/07/07 03:27:27]

I've just done this for things that might retain the owning object, i.e. the
owner passes |self| to the owned object.

 
   if (trackingArea_.get())
     [tabStripView_ removeTrackingArea:trackingArea_.get()];
 
   [newTabButton_ removeTrackingArea:newTabTrackingArea_.get()];
   // Invalidate all closing animations so they don't call back to us after
   // we're gone.
   for (TabController* controller in closingControllers_.get()) {
     NSView* view = [controller view];
     [[[view animationForKey:@"frameOrigin"] delegate] invalidate];
@@ skipping 1690 matching lines @@
                     forButtonState:image_button_cell::kHoverStateBackground];
   } else {
     [[newTabButton_ cell] setImage:nil
                     forButtonState:image_button_cell::kDefaultStateBackground];
     [[newTabButton_ cell] setImage:nil
                     forButtonState:image_button_cell::kHoverStateBackground];
   }
 }
 
 @end