[Mac] Inform reference counted objects that hold a weak Browser* when the Browser is being destroye…

chrome/browser/ui/cocoa/download/download_shelf_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/download/download_shelf_controller.h"
 
 #include "base/mac/bundle_locations.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/download/download_stats.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 99 matching lines @@
     [[self view] setFrame:frame];
 
     downloadItemControllers_.reset([[NSMutableArray alloc] init]);
 
     bridge_.reset(new DownloadShelfMac(browser, self));
     navigator_ = browser;
   }
   return self;
 }
 
+- (void)browserWillBeDestroyed {

[tapted, 2015/07/06 07:26:18]

should come after dealloc (init[WithFoo] and dealloc are usually paired together
in the .mm ... and I guess awakeFromNib is like an initWithFoo as well).

[jackhou1, 2015/07/07 03:27:27]

Done.

+  navigator_ = nullptr;
+}
+
 - (void)awakeFromNib {
   DCHECK(hoverCloseButton_);
 
   NSNotificationCenter* defaultCenter = [NSNotificationCenter defaultCenter];
   [[self animatableView] setResizeDelegate:resizeDelegate_];
   [[self view] setPostsFrameChangedNotifications:YES];
   [defaultCenter addObserver:self
                     selector:@selector(viewFrameDidChange:)
                         name:NSViewFrameDidChangeNotification
                       object:[self view]];
@@ skipping 374 matching lines @@
   }
 
   // Set the tracking off to create a new tracking area for the control.
   // When changing the bounds/frame on a HoverButton, the tracking isn't updated
   // correctly, it needs to be turned off and back on.
   [hoverCloseButton_ setTrackingEnabled:NO];
   [hoverCloseButton_ setFrame:bounds];
   [hoverCloseButton_ setTrackingEnabled:YES];
 }
 @end