Issue 1221153002: Switch SkyShell to its own ResourceExtractor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1221153002: Switch SkyShell to its own ResourceExtractor (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Switch SkyShell to its own ResourceExtractor This CL prepares us to have more interesting resources than base's ResourceExtractor understands. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/ab31e96cca541da272e8bf699e3609da42755e2f

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+211 lines, -15 lines)			Patch
M	sky/apk/rules.gni	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/shell/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	sky/shell/android/org/domokit/sky/shell/ResourceExtractor.java	View	1 chunk	+186 lines, -0 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/SkyApplication.java	View	2 chunks	+21 lines, -10 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/SkyMain.java	View	2 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

abarth-chromium

5 years, 5 months ago (2015-07-02 18:25:02 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ab31e96cca541da272e8bf699e3609da42755e2f (presubmit successful).