Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1221123003: SkyDemo should use explicit intents (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1, eseidel
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

SkyDemo should use explicit intents This CL switches SkyDemo over to using explicit intents for deciding which Sky apps to run. This change lets us get rid of the hacky "sky" URI scheme. Instead, we use normal URLs but we require the sender of the intent to be explicit in directing the VIEW intent to us. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/cdc727561c5fcd9cbf9c962ac3c19dfb1c23cc51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -41 lines) Patch
M sky/apk/demo/AndroidManifest.xml View 1 chunk +1 line, -6 lines 0 comments Download
M sky/apk/demo/org/domokit/sky/demo/SkyDemoActivity.java View 2 chunks +8 lines, -21 lines 0 comments Download
M sky/sdk/home.dart View 1 chunk +4 lines, -1 line 0 comments Download
M sky/services/intents/intents.mojom View 1 chunk +6 lines, -0 lines 0 comments Download
M sky/services/intents/src/org/domokit/intents/ActivityManagerImpl.java View 2 chunks +9 lines, -0 lines 0 comments Download
M sky/shell/android/org/domokit/sky/shell/SkyActivity.java View 2 chunks +5 lines, -2 lines 0 comments Download
M sky/tools/shelldb View 4 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-02 22:03:41 UTC) #1
abarth-chromium
Committed patchset #1 (id:1) manually as cdc727561c5fcd9cbf9c962ac3c19dfb1c23cc51 (presubmit successful).
5 years, 5 months ago (2015-07-02 22:41:50 UTC) #2
eseidel
I'm not sure i fully understand the goal here. I guess this makes sense from ...
5 years, 5 months ago (2015-07-06 15:56:55 UTC) #4
abarth-chromium
On 2015/07/06 at 15:56:55, eseidel wrote: > I'm not sure i fully understand the goal ...
5 years, 5 months ago (2015-07-06 16:01:09 UTC) #5
eseidel
5 years, 5 months ago (2015-07-06 16:03:23 UTC) #6
Message was sent while issue was closed.
OK.

Powered by Google App Engine
This is Rietveld 408576698