Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 12211143: cc: Prevent premature activation during prefer smoothness (Closed)

Created:
7 years, 10 months ago by enne (OOO)
Modified:
7 years, 10 months ago
Reviewers:
reveman
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

cc: Prevent premature activation during prefer smoothness The tile manager combines priorities from the pending and active tree for a single tile to figure out how to prioritize it. It does this based on the global tree priority. If the tile manager is in "prefer smoothness" mode, then the active tree's priority takes precedence over the pending tree's priority. For newly invalidated visible tiles, this means that the active tree gets an unprioritized NEVER_BIN and the pending tree gets a NOW_BIN. However, the NOW_BIN would get ignored entirely, the tile manager would not have any work for the pending tree (giving it all to prepainting the active tree), and so LayerTreeHostImpl would activate the tree, thinking there was no work to be done. However, these resources are likely not rasterized yet, and so there would be a white or low res flash before they appeared. This patch takes the global tree priority into account. If we are in "prefer smoothness" mode and resources aren't ready, don't activate the tree. This prevents these forms of flashing during scrolling and pinching. R=reveman@chromium.org BUG=175276 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M cc/layer_tree_host_impl.cc View 1 chunk +13 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
enne (OOO)
7 years, 10 months ago (2013-02-12 23:41:30 UTC) #1
reveman
lgtm
7 years, 10 months ago (2013-02-12 23:45:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/12211143/1
7 years, 10 months ago (2013-02-12 23:52:11 UTC) #3
nduca
7 years, 10 months ago (2013-02-13 03:33:14 UTC) #4
Message was sent while issue was closed.
Committed manually as r182107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698