Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: Source/WebCore/bindings/v8/ScheduledAction.cpp

Issue 12211130: Merge 142565 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/bindings/v8/ScheduledAction.cpp
===================================================================
--- Source/WebCore/bindings/v8/ScheduledAction.cpp (revision 142623)
+++ Source/WebCore/bindings/v8/ScheduledAction.cpp (working copy)
@@ -49,21 +49,28 @@
namespace WebCore {
-ScheduledAction::ScheduledAction(v8::Handle<v8::Context> context, v8::Handle<v8::Function> function, int argc, v8::Handle<v8::Value> argv[])
+ScheduledAction::ScheduledAction(v8::Handle<v8::Context> context, v8::Handle<v8::Function> function, int argc, v8::Handle<v8::Value> argv[], v8::Isolate* isolate)
: m_context(context)
, m_function(function)
, m_code(String(), KURL(), TextPosition::belowRangePosition())
+ , m_isolate(isolate)
{
- v8::Isolate* isolate = m_context->GetIsolate();
m_args.reserveCapacity(argc);
for (int i = 0; i < argc; ++i)
- m_args.append(v8::Persistent<v8::Value>::New(isolate, argv[i]));
+ m_args.append(v8::Persistent<v8::Value>::New(m_isolate, argv[i]));
}
+ScheduledAction::ScheduledAction(v8::Handle<v8::Context> context, const String& code, const KURL& url, v8::Isolate* isolate)
+ : m_context(context)
+ , m_code(code, url)
+ , m_isolate(isolate)
+{
+}
+
ScheduledAction::~ScheduledAction()
{
for (size_t i = 0; i < m_args.size(); ++i) {
- m_args[i].Dispose(m_context->GetIsolate());
+ m_args[i].Dispose(m_isolate);
m_args[i].Clear();
}
}
« no previous file with comments | « Source/WebCore/bindings/v8/ScheduledAction.h ('k') | Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698