src/hydrogen.cc - Issue 12211128: Don't try to unlink instructions twice during GVN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 12211128: Don't try to unlink instructions twice during GVN (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 7869d71687cf5d4f2554fcc3323ee554a6a193f2..e1cf70a0250cb2f281dda7e356fd318b7778754a 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -2720,7 +2720,8 @@ void HGlobalValueNumberer::AnalyzeGraph() {

map->Add(instr, zone());

}

- if (instr->CheckFlag(HValue::kTrackSideEffectDominators)) {

+ if (instr->IsLinked() &&

+ instr->CheckFlag(HValue::kTrackSideEffectDominators)) {

for (int i = 0; i < kNumberOfTrackedSideEffects; i++) {

HValue* other = dominators->at(i);

GVNFlag changes_flag = HValue::ChangesFlagFromInt(i);

« no previous file with comments | « no previous file | no next file » | no next file with comments »