chrome/browser/ui/views/website_settings/website_settings_popup_view.cc - Issue 12211122: Reland Remove NativeTabbedPane[Win|Wrapper]; promote Views impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 12211122: Reland Remove NativeTabbedPane[Win|Wrapper]; promote Views impl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix leak of tab content Views. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/collected_cookies_views.cc ('k') | ui/views/controls/tabbed_pane/native_tabbed_pane_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

index f68dc04becb88ea6844f903e8b0f36891ece3351..237b075140da33d6cc159627081dd3b0ff6e0bf2 100644

--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

@@ -322,14 +322,12 @@ WebsiteSettingsPopupView::WebsiteSettingsPopupView(

tabbed_pane_->AddTabAtIndex(

TAB_ID_PERMISSIONS,

l10n_util::GetStringUTF16(IDS_WEBSITE_SETTINGS_TAB_LABEL_PERMISSIONS),

- CreatePermissionsTab(),

- true);

+ CreatePermissionsTab());

connection_tab_ = CreateConnectionTab();

tabbed_pane_->AddTabAtIndex(

TAB_ID_CONNECTION,

l10n_util::GetStringUTF16(IDS_WEBSITE_SETTINGS_TAB_LABEL_CONNECTION),

- connection_tab_,

- true);

+ connection_tab_);

DCHECK_EQ(tabbed_pane_->GetTabCount(), NUM_TAB_IDS);

tabbed_pane_->set_listener(this);

« no previous file with comments | « chrome/browser/ui/views/collected_cookies_views.cc ('k') | ui/views/controls/tabbed_pane/native_tabbed_pane_views.h » ('j') | no next file with comments »