DescriptionReland Remove NativeTabbedPane[Win|Wrapper]; promote Views impl.
Original CL (reverted for leaks): https://codereview.chromium.org/12225042/
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20Heapcheck/builds/14990
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/22339
Leaks are fixed here by having the tabbed pane own its tab content Views.
(all Valgrind and Heapcheck leaks observed locally are fixed by this change)
TBR=sky@chromium.org
The original CL description is copied below:
========================================
Remove NativeTabbedPane[Win|Wrapper]; promote Views impl.
Remove NativeTabbedPaneWin and NativeTabbedPaneWrapper.
( its last use was eliminated in http://crrev.com/180924 )
Write a TabbedPane based on NativeTabbedPaneViews.
Update unit tests; cleanup; etc.
BUG=138059
TEST=No observable tabbed pane appearance/behavior changes (see the WebsiteSettingsPopupView and CollectedCookiesView); unit tests.
R=markusheintz@chromium.org,sky@chromium.org,ben@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181945
Patch Set 1 #Patch Set 2 : Fix leak of tab content Views. #Messages
Total messages: 3 (0 generated)
|