chrome/browser/ui/sync/one_click_signin_helper.cc - Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments, merge to LKGR. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_impl.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/one_click_signin_helper.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc

index 3ace6dda9afa486870947a3eafa5c0dacd59f9da..6db05b1f85288152fecd4dfa8d4ceecc3ddd1ec3 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc

@@ -15,6 +15,7 @@

#include "base/compiler_specific.h"

#include "base/metrics/field_trial.h"

#include "base/metrics/histogram.h"

+#include "base/prefs/pref_service.h"

#include "base/string_split.h"

#include "base/string_util.h"

#include "base/supports_user_data.h"

@@ -24,7 +25,6 @@

#include "chrome/browser/browser_process.h"

#include "chrome/browser/defaults.h"

#include "chrome/browser/google/google_util.h"

-#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/prefs/scoped_user_pref_update.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_info_cache.h"

@@ -45,11 +45,11 @@

#include "chrome/browser/ui/sync/one_click_signin_sync_starter.h"

#include "chrome/browser/ui/tab_modal_confirm_dialog.h"

#include "chrome/browser/ui/tab_modal_confirm_dialog_delegate.h"

-#include "chrome/common/one_click_signin_messages.h"

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/chrome_version_info.h"

#include "chrome/common/net/url_util.h"

+#include "chrome/common/one_click_signin_messages.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/browser_thread.h"