chrome/browser/prefs/pref_service_syncable.cc - Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_service_syncable.cc

Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments, merge to LKGR. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/prefs/pref_service_syncable.cc

diff --git a/chrome/browser/prefs/pref_service_syncable.cc b/chrome/browser/prefs/pref_service_syncable.cc

index d6fe226d0c0a7ff530e59a2634d750e0978baea0..cf1ab7a54b8b22226d9c90d83da34f2da28e101a 100644

--- a/chrome/browser/prefs/pref_service_syncable.cc

+++ b/chrome/browser/prefs/pref_service_syncable.cc

@@ -8,14 +8,14 @@

#include "base/file_path.h"

#include "base/prefs/default_pref_store.h"

#include "base/prefs/overlay_user_pref_store.h"

+#include "base/prefs/pref_notifier_impl.h"

+#include "base/prefs/pref_registry.h"

+#include "base/prefs/pref_value_store.h"

#include "base/strings/string_number_conversions.h"

#include "base/value_conversions.h"

#include "chrome/browser/prefs/pref_model_associator.h"

-#include "chrome/browser/prefs/pref_notifier_impl.h"

-#include "chrome/browser/prefs/pref_registry.h"

#include "chrome/browser/prefs/pref_registry_syncable.h"

#include "chrome/browser/prefs/pref_service_syncable_observer.h"

-#include "chrome/browser/prefs/pref_value_store.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/prefs/prefs_tab_helper.h"

« no previous file with comments | « chrome/browser/prefs/pref_service_syncable.h ('k') | chrome/browser/prefs/pref_service_syncable_builder.h » ('j') | no next file with comments »