base/base.gyp - Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base.gyp

Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments, merge to LKGR. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/base.gyp

diff --git a/base/base.gyp b/base/base.gyp

index 4d775981f44c4d61d795a6c429a36b2da05e97fc..2793e538f5fb324e8f7041866c6dc7112e04b8bd 100644

--- a/base/base.gyp

+++ b/base/base.gyp

@@ -331,6 +331,7 @@

'BASE_PREFS_IMPLEMENTATION',

'sources': [

+ 'prefs/base_prefs_export.h',

'prefs/default_pref_store.cc',

'prefs/default_pref_store.h',

'prefs/json_pref_store.cc',

@@ -339,11 +340,23 @@

'prefs/overlay_user_pref_store.h',

'prefs/persistent_pref_store.h',

'prefs/pref_notifier.h',

+ 'prefs/pref_notifier_impl.cc',

+ 'prefs/pref_notifier_impl.h',

'prefs/pref_observer.h',

+ 'prefs/pref_registry.cc',

+ 'prefs/pref_registry.h',

+ 'prefs/pref_registry_simple.cc',

+ 'prefs/pref_registry_simple.h',

+ 'prefs/pref_service.cc',

+ 'prefs/pref_service.h',

+ 'prefs/pref_service_builder.cc',

+ 'prefs/pref_service_builder.h',

'prefs/pref_store.cc',

'prefs/pref_store.h',

'prefs/pref_value_map.cc',

'prefs/pref_value_map.h',

+ 'prefs/pref_value_store.cc',

+ 'prefs/pref_value_store.h',

'prefs/public/pref_change_registrar.cc',

'prefs/public/pref_change_registrar.h',

'prefs/public/pref_member.cc',

@@ -362,6 +375,7 @@

'../testing/gmock.gyp:gmock',

'sources': [

+ 'prefs/mock_pref_change_callback.cc',

'prefs/pref_store_observer_mock.cc',

'prefs/pref_store_observer_mock.h',

'prefs/testing_pref_store.cc',

@@ -507,8 +521,10 @@

'posix/unix_domain_socket_linux_unittest.cc',

'pr_time_unittest.cc',

'prefs/json_pref_store_unittest.cc',

+ 'prefs/mock_pref_change_callback.h',

'prefs/overlay_user_pref_store_unittest.cc',

'prefs/pref_value_map_unittest.cc',

+ 'prefs/pref_value_store_unittest.cc',

'process_util_unittest.cc',

'process_util_unittest_ios.cc',

'process_util_unittest_mac.h',

@@ -597,6 +613,7 @@

'dependencies': [

'base',

'base_i18n',

+ 'base_prefs',

'base_prefs_test_support',

'base_static',

'run_all_unittests',

« no previous file with comments | « .gitmodules ('k') | base/prefs/mock_pref_change_callback.h » ('j') | no next file with comments »