chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc - Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc

Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments, merge to LKGR. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/webui/crashes_ui.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/auto_reset.h"	5 #include "base/auto_reset.h"

6 #include "base/files/scoped_temp_dir.h"	6 #include "base/files/scoped_temp_dir.h"

7 #include "base/json/json_reader.h"	7 #include "base/json/json_reader.h"

	8 #include "base/prefs/pref_service.h"

8 #include "base/values.h"	9 #include "base/values.h"

9 #include "chrome/browser/history/download_row.h"	10 #include "chrome/browser/history/download_row.h"

10 #include "chrome/browser/prefs/pref_service.h"

11 #include "chrome/browser/profiles/profile.h"	11 #include "chrome/browser/profiles/profile.h"

12 #include "chrome/browser/ui/browser.h"	12 #include "chrome/browser/ui/browser.h"

13 #include "chrome/browser/ui/webui/downloads_dom_handler.h"	13 #include "chrome/browser/ui/webui/downloads_dom_handler.h"

14 #include "chrome/common/pref_names.h"	14 #include "chrome/common/pref_names.h"

15 #include "chrome/test/base/in_process_browser_test.h"	15 #include "chrome/test/base/in_process_browser_test.h"

16 #include "chrome/test/base/ui_test_utils.h"	16 #include "chrome/test/base/ui_test_utils.h"

17 #include "content/public/browser/web_contents.h"	17 #include "content/public/browser/web_contents.h"

18	18

19 namespace {	19 namespace {

20	20

(...skipping 167 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
188 // TODO(benjhayden): Test incognito, both downloads_list() and that on-record	188 // TODO(benjhayden): Test incognito, both downloads_list() and that on-record

189 // calls can't access off-record items.	189 // calls can't access off-record items.

190	190

191 // TODO(benjhayden): Test that bad download ids incoming from the javascript are	191 // TODO(benjhayden): Test that bad download ids incoming from the javascript are

192 // dropped on the floor.	192 // dropped on the floor.

193	193

194 // TODO(benjhayden): Test that IsTemporary() downloads are not shown.	194 // TODO(benjhayden): Test that IsTemporary() downloads are not shown.

195	195

196 // TODO(benjhayden): Test that RemoveObserver is called on all download items,	196 // TODO(benjhayden): Test that RemoveObserver is called on all download items,

197 // including items that crossed IsTemporary() and back.	197 // including items that crossed IsTemporary() and back.

OLD	NEW