chrome/browser/tab_contents/spellchecker_submenu_observer_browsertest.cc - Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/tab_contents/spellchecker_submenu_observer_browsertest.cc

Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments, merge to LKGR. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/tab_contents/render_view_context_menu_unittest.cc ('k') | chrome/browser/tab_contents/spellchecker_submenu_observer_hunspell.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/tab_contents/spellchecker_submenu_observer.h"	5 #include "chrome/browser/tab_contents/spellchecker_submenu_observer.h"

6	6

	7 #include "base/prefs/pref_service.h"

7 #include "base/utf_string_conversions.h"	8 #include "base/utf_string_conversions.h"

8 #include "chrome/app/chrome_command_ids.h"	9 #include "chrome/app/chrome_command_ids.h"

9 #include "chrome/browser/prefs/pref_service.h"

10 #include "chrome/browser/tab_contents/render_view_context_menu.h"	10 #include "chrome/browser/tab_contents/render_view_context_menu.h"

11 #include "chrome/browser/tab_contents/render_view_context_menu_observer.h"	11 #include "chrome/browser/tab_contents/render_view_context_menu_observer.h"

12 #include "chrome/common/pref_names.h"	12 #include "chrome/common/pref_names.h"

13 #include "chrome/test/base/in_process_browser_test.h"	13 #include "chrome/test/base/in_process_browser_test.h"

14 #include "chrome/test/base/testing_profile.h"	14 #include "chrome/test/base/testing_profile.h"

15	15

16 using content::RenderViewHost;	16 using content::RenderViewHost;

17 using content::WebContents;	17 using content::WebContents;

18	18

19 namespace {	19 namespace {

(...skipping 127 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
147 EXPECT_TRUE(menu->IsCommandIdChecked(IDC_CHECK_SPELLING_WHILE_TYPING));	147 EXPECT_TRUE(menu->IsCommandIdChecked(IDC_CHECK_SPELLING_WHILE_TYPING));

148	148

149 // Select this item and verify that the "Check Spelling While Typing" item is	149 // Select this item and verify that the "Check Spelling While Typing" item is

150 // not checked. Also, verify that the value of "browser.enable_spellchecking"	150 // not checked. Also, verify that the value of "browser.enable_spellchecking"

151 // is now false.	151 // is now false.

152 menu->ExecuteCommand(IDC_CHECK_SPELLING_WHILE_TYPING);	152 menu->ExecuteCommand(IDC_CHECK_SPELLING_WHILE_TYPING);

153 EXPECT_FALSE(	153 EXPECT_FALSE(

154 menu->GetPrefs()->GetBoolean(prefs::kEnableContinuousSpellcheck));	154 menu->GetPrefs()->GetBoolean(prefs::kEnableContinuousSpellcheck));

155 EXPECT_FALSE(menu->IsCommandIdChecked(IDC_CHECK_SPELLING_WHILE_TYPING));	155 EXPECT_FALSE(menu->IsCommandIdChecked(IDC_CHECK_SPELLING_WHILE_TYPING));

156 }	156 }

OLD	NEW