chrome/browser/extensions/extension_tabs_apitest.cc - Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments, merge to LKGR. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/extension_system.cc ('k') | chrome/browser/extensions/extension_toolbar_model.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/extension_apitest.h"	5 #include "chrome/browser/extensions/extension_apitest.h"

6	6

	7 #include "base/prefs/pref_service.h"

7 #include "chrome/browser/prefs/incognito_mode_prefs.h"	8 #include "chrome/browser/prefs/incognito_mode_prefs.h"

8 #include "chrome/browser/prefs/pref_service.h"

9 #include "chrome/browser/profiles/profile.h"	9 #include "chrome/browser/profiles/profile.h"

10 #include "chrome/browser/ui/browser.h"	10 #include "chrome/browser/ui/browser.h"

11 #include "chrome/browser/ui/browser_window.h"	11 #include "chrome/browser/ui/browser_window.h"

12 #include "chrome/common/chrome_switches.h"	12 #include "chrome/common/chrome_switches.h"

13 #include "chrome/common/pref_names.h"	13 #include "chrome/common/pref_names.h"

14 #include "chrome/common/url_constants.h"	14 #include "chrome/common/url_constants.h"

15 #include "net/base/mock_host_resolver.h"	15 #include "net/base/mock_host_resolver.h"

16	16

17 // Possible race in ChromeURLDataManager. http://crbug.com/59198	17 // Possible race in ChromeURLDataManager. http://crbug.com/59198

18 #if defined(OS_MACOSX) \|\| defined(OS_LINUX)	18 #if defined(OS_MACOSX) \|\| defined(OS_LINUX)

(...skipping 225 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
244 << message_;	244 << message_;

245 }	245 }

246 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) {	246 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) {

247 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))	247 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))

248 << message_;	248 << message_;

249 }	249 }

250	250

251 // Adding a new test? Awesome. But API tests are the old hotness. The	251 // Adding a new test? Awesome. But API tests are the old hotness. The

252 // new hotness is extension_test_utils. See tabs_test.cc for an example.	252 // new hotness is extension_test_utils. See tabs_test.cc for an example.

253 // We are trying to phase out many uses of API tests as they tend to be flaky.	253 // We are trying to phase out many uses of API tests as they tend to be flaky.

OLD	NEW