chrome/browser/browsing_data/browsing_data_remover_browsertest.cc - Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/browsing_data/browsing_data_remover_browsertest.cc

Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments, merge to LKGR. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/browser_shutdown.cc ('k') | chrome/browser/browsing_data/cookies_tree_model_unittest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/file_path.h"	5 #include "base/file_path.h"

6 #include "base/path_service.h"	6 #include "base/path_service.h"

	7 #include "base/prefs/pref_service.h"

7 #include "chrome/browser/browsing_data/browsing_data_helper.h"	8 #include "chrome/browser/browsing_data/browsing_data_helper.h"

8 #include "chrome/browser/browsing_data/browsing_data_remover.h"	9 #include "chrome/browser/browsing_data/browsing_data_remover.h"

9 #include "chrome/browser/prefs/pref_service.h"

10 #include "chrome/browser/profiles/profile.h"	10 #include "chrome/browser/profiles/profile.h"

11 #include "chrome/browser/ui/browser.h"	11 #include "chrome/browser/ui/browser.h"

12 #include "chrome/browser/ui/tabs/tab_strip_model.h"	12 #include "chrome/browser/ui/tabs/tab_strip_model.h"

13 #include "chrome/common/chrome_notification_types.h"	13 #include "chrome/common/chrome_notification_types.h"

14 #include "chrome/common/pref_names.h"	14 #include "chrome/common/pref_names.h"

15 #include "chrome/test/base/in_process_browser_test.h"	15 #include "chrome/test/base/in_process_browser_test.h"

16 #include "chrome/test/base/ui_test_utils.h"	16 #include "chrome/test/base/ui_test_utils.h"

17 #include "content/public/browser/browser_context.h"	17 #include "content/public/browser/browser_context.h"

18 #include "content/public/browser/browser_thread.h"	18 #include "content/public/browser/browser_thread.h"

19 #include "content/public/browser/download_manager.h"	19 #include "content/public/browser/download_manager.h"

(...skipping 89 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
109 ui_test_utils::NavigateToURL(browser(), url);	109 ui_test_utils::NavigateToURL(browser(), url);

110 RunScriptAndCheckResult("createTable()", "done");	110 RunScriptAndCheckResult("createTable()", "done");

111 RunScriptAndCheckResult("insertRecord('text2')", "done");	111 RunScriptAndCheckResult("insertRecord('text2')", "done");

112 RunScriptAndCheckResult("getRecords()", "text2");	112 RunScriptAndCheckResult("getRecords()", "text2");

113 }	113 }

114	114

115 // Profile::ClearNetworkingHistorySince should be exercised here too see whether	115 // Profile::ClearNetworkingHistorySince should be exercised here too see whether

116 // the call gets delegated through ProfileIO[Impl]Data properly, which is hard	116 // the call gets delegated through ProfileIO[Impl]Data properly, which is hard

117 // to write unit-tests for. Currently this is done by both of the above tests.	117 // to write unit-tests for. Currently this is done by both of the above tests.

118 // Add standalone test if this changes.	118 // Add standalone test if this changes.

OLD	NEW