Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: base/prefs/pref_service.cc

Issue 12211105: Move remaining non-test, non-Chrome-specific Prefs code to base/prefs/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments, merge to LKGR. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/prefs/pref_service.h ('k') | base/prefs/pref_service_builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prefs/pref_service.h" 5 #include "base/prefs/pref_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/file_path.h" 10 #include "base/file_path.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/message_loop.h" 12 #include "base/message_loop.h"
13 #include "base/metrics/histogram.h" 13 #include "base/metrics/histogram.h"
14 #include "base/prefs/default_pref_store.h" 14 #include "base/prefs/default_pref_store.h"
15 #include "base/prefs/pref_notifier_impl.h"
16 #include "base/prefs/pref_registry.h"
17 #include "base/prefs/pref_value_store.h"
15 #include "base/stl_util.h" 18 #include "base/stl_util.h"
16 #include "base/string_util.h" 19 #include "base/string_util.h"
17 #include "base/strings/string_number_conversions.h" 20 #include "base/strings/string_number_conversions.h"
18 #include "base/value_conversions.h" 21 #include "base/value_conversions.h"
19 #include "build/build_config.h" 22 #include "build/build_config.h"
20 #include "chrome/browser/prefs/pref_notifier_impl.h"
21 #include "chrome/browser/prefs/pref_registry.h"
22 #include "chrome/browser/prefs/pref_value_store.h"
23 23
24 using content::BrowserContext; 24 using content::BrowserContext;
25 25
26 namespace { 26 namespace {
27 27
28 class ReadErrorHandler : public PersistentPrefStore::ReadErrorDelegate { 28 class ReadErrorHandler : public PersistentPrefStore::ReadErrorDelegate {
29 public: 29 public:
30 ReadErrorHandler(base::Callback<void(PersistentPrefStore::PrefReadError)> cb) 30 ReadErrorHandler(base::Callback<void(PersistentPrefStore::PrefReadError)> cb)
31 : callback_(cb) {} 31 : callback_(cb) {}
32 32
(...skipping 555 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 DCHECK(found_value->IsType(default_type)); 588 DCHECK(found_value->IsType(default_type));
589 return found_value; 589 return found_value;
590 } else { 590 } else {
591 // Every registered preference has at least a default value. 591 // Every registered preference has at least a default value.
592 NOTREACHED() << "no valid value found for registered pref " << path; 592 NOTREACHED() << "no valid value found for registered pref " << path;
593 } 593 }
594 } 594 }
595 595
596 return NULL; 596 return NULL;
597 } 597 }
OLDNEW
« no previous file with comments | « base/prefs/pref_service.h ('k') | base/prefs/pref_service_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698