Issue 12211095: Add additional flags to control array abuse tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12211095: Add additional flags to control array abuse tracing (Closed)

Created:
7 years, 10 months ago by danno

Modified:
7 years, 10 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add additional flags to control array abuse tracing R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=13632

Patch Set 1 #

Total comments: 1

Patch Set 2 : Tweaks #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -9 lines)			Patch
M	src/elements.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/elements.cc	View	1	3 chunks	+13 lines, -4 lines	0 comments	Download
	src/flag-definitions.h	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	src/objects.cc	View		1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

7 years, 10 months ago (2013-02-08 14:20:54 UTC) #2

lgtm

https://codereview.chromium.org/12211095/diff/1/src/elements.h
File src/elements.h (right):

https://codereview.chromium.org/12211095/diff/1/src/elements.h#newcode201
src/elements.h:201: bool allow_list_append_growth = false);
s/allow_list_append_growth/allow_appending/ for simplification?

Expand Messages | Collapse Messages