[Media Galleries] Populate volume metadata in ChromeOS/Linux

chrome/browser/storage_monitor/removable_device_notifications_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // chromeos::RemovableDeviceNotificationsCros implementation.
 
 #include "chrome/browser/storage_monitor/removable_device_notifications_chromeos.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "base/string_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/storage_monitor/media_device_notifications_utils.h"
 #include "chrome/browser/storage_monitor/media_storage_util.h"
 #include "chrome/browser/storage_monitor/removable_device_constants.h"
 #include "content/public/browser/browser_thread.h"
 
 namespace chromeos {
 
 namespace {
 
 // Constructs a device name using label or manufacturer (vendor and product)
 // name details.
-string16 GetDeviceName(const disks::DiskMountManager::Disk& disk) {
+string16 GetDeviceName(const disks::DiskMountManager::Disk& disk,
+                       string16* storage_label,
+                       string16* vendor_name,
+                       string16* model_name) {
   if (disk.device_type() == DEVICE_TYPE_SD) {
     // Mount path of an SD card will be one of the following:
     // (1) /media/removable/<volume_label>
     // (2) /media/removable/SD Card
     // If the volume label is available, mount path will be (1) else (2).
     base::FilePath mount_point(disk.mount_path());
     const string16 display_name(mount_point.BaseName().LossyDisplayName());
     if (!display_name.empty())
       return display_name;
   }
 
   const std::string& device_label = disk.device_label();
+
+  if (storage_label)
+    *storage_label = UTF8ToUTF16(device_label);
+  if (vendor_name)
+    *vendor_name = UTF8ToUTF16(disk.vendor_name());
+  if (model_name)
+    *model_name = UTF8ToUTF16(disk.product_name());
+
   if (!device_label.empty() && IsStringUTF8(device_label))
     return UTF8ToUTF16(device_label);
+
   return chrome::GetFullProductName(disk.vendor_name(), disk.product_name());
 }
 
 // Constructs a device id using uuid or manufacturer (vendor and product) id
 // details.
 std::string MakeDeviceUniqueId(const disks::DiskMountManager::Disk& disk) {
   std::string uuid = disk.fs_uuid();
   if (!uuid.empty())
     return chrome::kFSUniqueIdPrefix + uuid;
 
   // If one of the vendor or product information is missing, its value in the
   // string is empty.
   // Format: VendorModelSerial:VendorInfo:ModelInfo:SerialInfo
   // TODO(kmadhusu) Extract serial information for the disks and append it to
   // the device unique id.
   const std::string& vendor = disk.vendor_id();
   const std::string& product = disk.product_id();
   if (vendor.empty() && product.empty())
     return std::string();
   return chrome::kVendorModelSerialPrefix + vendor + ":" + product + ":";
 }
 
 // Returns true if the requested device is valid, else false. On success, fills
 // in |unique_id|, |device_label| and |storage_size_in_bytes|.
 bool GetDeviceInfo(const std::string& source_path,
                    std::string* unique_id,
                    string16* device_label,
-                   uint64* storage_size_in_bytes) {
+                   uint64* storage_size_in_bytes,
+                   string16* storage_label,
+                   string16* vendor_name,
+                   string16* model_name) {
   const disks::DiskMountManager::Disk* disk =
       disks::DiskMountManager::GetInstance()->FindDiskBySourcePath(source_path);
   if (!disk || disk->device_type() == DEVICE_TYPE_UNKNOWN)
     return false;
 
   if (unique_id)
     *unique_id = MakeDeviceUniqueId(*disk);
 
   if (device_label)
-    *device_label = GetDeviceName(*disk);
+    *device_label = GetDeviceName(*disk, storage_label,
+                                  vendor_name, model_name);
 
   if (storage_size_in_bytes)
     *storage_size_in_bytes = disk->total_size_in_bytes();
   return true;
 }
 
 }  // namespace
 
 using content::BrowserThread;
 
@@ skipping 60 matching lines @@
           BrowserThread::FILE, FROM_HERE,
           base::Bind(
               &RemovableDeviceNotificationsCros::CheckMountedPathOnFileThread,
               this, mount_info));
       break;
     }
     case disks::DiskMountManager::UNMOUNTING: {
       MountMap::iterator it = mount_map_.find(mount_info.mount_path);
       if (it == mount_map_.end())
         return;
-      receiver()->ProcessDetach(it->second.storage_info.device_id);
+      receiver()->ProcessDetach(it->second.device_id);
       mount_map_.erase(it);
       break;
     }
   }
 }
 
 void RemovableDeviceNotificationsCros::OnFormatEvent(
     disks::DiskMountManager::FormatEvent event,
     FormatError error_code,
     const std::string& device_path) {
 }
 
 bool RemovableDeviceNotificationsCros::GetStorageInfoForPath(
     const base::FilePath& path,
     StorageInfo* device_info) const {
   if (!path.IsAbsolute())
     return false;
 
   base::FilePath current = path;
   while (!ContainsKey(mount_map_, current.value()) &&
          current != current.DirName()) {
     current = current.DirName();
   }
 
   MountMap::const_iterator info_it = mount_map_.find(current.value());
   if (info_it == mount_map_.end())
     return false;
 
   if (device_info)
-    *device_info = info_it->second.storage_info;
+    *device_info = info_it->second;
   return true;
 }
 
 uint64 RemovableDeviceNotificationsCros::GetStorageSize(
     const std::string& device_location) const {
   MountMap::const_iterator info_it = mount_map_.find(device_location);
   return (info_it != mount_map_.end()) ?
-      info_it->second.storage_size_in_bytes : 0;
+      info_it->second.total_size_in_bytes : 0;
 }
 
 void RemovableDeviceNotificationsCros::CheckMountedPathOnFileThread(
     const disks::DiskMountManager::MountPointInfo& mount_info) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
   bool has_dcim = chrome::IsMediaDevice(mount_info.mount_path);
 
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&RemovableDeviceNotificationsCros::AddMountedPathOnUIThread,
                  this, mount_info, has_dcim));
 }
 
 void RemovableDeviceNotificationsCros::AddMountedPathOnUIThread(
     const disks::DiskMountManager::MountPointInfo& mount_info, bool has_dcim) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   if (ContainsKey(mount_map_, mount_info.mount_path)) {
     // CheckExistingMountPointsOnUIThread() added the mount point information
     // in the map before the device attached handler is called. Therefore, an
     // entry for the device already exists in the map.
     return;
   }
 
   // Get the media device uuid and label if exists.
   std::string unique_id;
   string16 device_label;
+  string16 storage_label;
+  string16 vendor_name;
+  string16 model_name;
   uint64 storage_size_in_bytes;
   if (!GetDeviceInfo(mount_info.source_path, &unique_id, &device_label,
-                     &storage_size_in_bytes))
+                     &storage_size_in_bytes, &storage_label,
+                     &vendor_name, &model_name))
     return;
 
   // Keep track of device uuid and label, to see how often we receive empty
   // values.
   chrome::MediaStorageUtil::RecordDeviceInfoHistogram(true, unique_id,
                                                       device_label);
   if (unique_id.empty() || device_label.empty())
     return;
 
   chrome::MediaStorageUtil::Type type = has_dcim ?
       chrome::MediaStorageUtil::REMOVABLE_MASS_STORAGE_WITH_DCIM :
       chrome::MediaStorageUtil::REMOVABLE_MASS_STORAGE_NO_DCIM;
 
   std::string device_id = chrome::MediaStorageUtil::MakeDeviceId(type,
                                                                  unique_id);
-  StorageObjectInfo object_info = {
-      StorageInfo(device_id, device_label, mount_info.mount_path),
-      storage_size_in_bytes
-  };
-  mount_map_.insert(std::make_pair(mount_info.mount_path, object_info));
-  receiver()->ProcessAttach(StorageInfo(
+  StorageInfo object_info(
       device_id,
       chrome::GetDisplayNameForDevice(storage_size_in_bytes, device_label),
-      mount_info.mount_path));
+      mount_info.mount_path);
+  object_info.total_size_in_bytes = storage_size_in_bytes;

[vandebo (ex-Chrome), 2013/03/01 22:21:48]

This is weird....  The constructor is just a helper to populate fields, so
should it take all the fields?

[Greg Billock, 2013/03/05 19:20:55]

Yes, we should have a constructor like that. I'm going to leave that for after
the refactor though.

[vandebo (ex-Chrome), 2013/03/06 01:34:54]

If you like.  But if so, add a TODO here so that we don't forget about it.

[Greg Billock, 2013/03/06 23:24:25]

Refactor is in, just updated constructor.

+  object_info.storage_label = storage_label;
+  object_info.vendor_name = vendor_name;
+  object_info.model_name = model_name;
+
+  mount_map_.insert(std::make_pair(mount_info.mount_path, object_info));
+
+  receiver()->ProcessAttach(object_info);
 }
 
 }  // namespace chromeos