Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: net/url_request/test_url_fetcher_factory.cc

Issue 12211076: Refactored FakeURLFetcher to make it more flexible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix lint issue Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/test_url_fetcher_factory.cc
diff --git a/net/url_request/test_url_fetcher_factory.cc b/net/url_request/test_url_fetcher_factory.cc
index e645329f7f99c112a3430f7286f279b8caa6b3ff..6dfc3e5cdaf7d658cefc7d2ca525678f796e1865 100644
--- a/net/url_request/test_url_fetcher_factory.cc
+++ b/net/url_request/test_url_fetcher_factory.cc
@@ -340,8 +340,10 @@ URLFetcher* FakeURLFetcherFactory::CreateURLFetcher(
const GURL& url,
URLFetcher::RequestType request_type,
URLFetcherDelegate* d) {
- FakeResponseMap::const_iterator it = fake_responses_.find(url);
- if (it == fake_responses_.end()) {
+ TestURLFetcher* fake_url_fetcher_ =
+ CreateFakeURLFetcher(url, request_type, d);
+
+ if (fake_url_fetcher_ == NULL) {
if (default_factory_ == NULL) {
// If we don't have a baked response for that URL we return NULL.
DLOG(ERROR) << "No baked response for URL: " << url.spec();
@@ -350,6 +352,18 @@ URLFetcher* FakeURLFetcherFactory::CreateURLFetcher(
return default_factory_->CreateURLFetcher(id, url, request_type, d);
}
}
+ return fake_url_fetcher_;
+}
+
+
+TestURLFetcher* FakeURLFetcherFactory::CreateFakeURLFetcher(
+ const GURL& url,
+ URLFetcher::RequestType request_type,
+ URLFetcherDelegate* d) {
+ FakeResponseMap::const_iterator it = fake_responses_.find(url);
+ if (it == fake_responses_.end()) {
+ return NULL;
+ }
return new FakeURLFetcher(url, d, it->second.first, it->second.second);
}
« net/url_request/test_url_fetcher_factory.h ('K') | « net/url_request/test_url_fetcher_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698