Change prototypes to yuv_convert_simd_x86 yasm and equivalent C to portably sign extend int args

media/base/simd/convert_yuv_to_rgb.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_SIMD_CONVERT_YUV_TO_RGB_H_
 #define MEDIA_BASE_SIMD_CONVERT_YUV_TO_RGB_H_
 
 #include "base/basictypes.h"
 #include "media/base/yuv_convert.h"
 
@@ skipping 41 matching lines @@
                            int ystride,
                            int uvstride,
                            int rgbstride,
                            YUVType yuv_type);
 
 }  // namespace media
 
 // Assembly functions are declared without namespace.
 extern "C" {
 
+// We use ptrdiff_t instead of int for yasm routine parameters to portably
+// sign-extend int. On Win64, MSVC does not sign-extend the value in the stack
+// home of int function parameters, and yasm routines are unaware of this lack
+// of extension and fault.  ptrdiff_t is portably sign-extended and fixes this
+// issue on at least Win64.  The C-equivalent RowProc versions' prototypes
+// include the same change to ptrdiff_t to reuse the typedefs.
+

[wolenetz, 2013/02/12 19:52:12]

I'll remove this extra space in PS3.  Sorry this one crept through!

[wolenetz, 2013/02/12 22:30:05]

Done.

+
 typedef void (*ConvertYUVToRGB32RowProc)(const uint8*,
                                           const uint8*,
                                           const uint8*,
                                           uint8*,
-                                          int);
+                                          ptrdiff_t);
+
 typedef void (*ScaleYUVToRGB32RowProc)(const uint8*,
                                        const uint8*,
                                        const uint8*,
                                        uint8*,
-                                       int,
-                                       int);
+                                       ptrdiff_t,
+                                       ptrdiff_t);
 
 void ConvertYUVToRGB32Row_C(const uint8* yplane,
                             const uint8* uplane,
                             const uint8* vplane,
                             uint8* rgbframe,
-                            int width);
+                            ptrdiff_t width);
 
 void ConvertYUVToRGB32Row_MMX(const uint8* yplane,
                               const uint8* uplane,
                               const uint8* vplane,
                               uint8* rgbframe,
-                              int width);
+                              ptrdiff_t width);
 
 void ConvertYUVToRGB32Row_SSE(const uint8* yplane,
                               const uint8* uplane,
                               const uint8* vplane,
                               uint8* rgbframe,
-                              int width);
+                              ptrdiff_t width);
 
 void ScaleYUVToRGB32Row_C(const uint8* y_buf,
                           const uint8* u_buf,
                           const uint8* v_buf,
                           uint8* rgb_buf,
-                          int width,
-                          int source_dx);
+                          ptrdiff_t width,
+                          ptrdiff_t source_dx);
 
 void ScaleYUVToRGB32Row_MMX(const uint8* y_buf,
                             const uint8* u_buf,
                             const uint8* v_buf,
                             uint8* rgb_buf,
-                            int width,
-                            int source_dx);
+                            ptrdiff_t width,
+                            ptrdiff_t source_dx);
 
 void ScaleYUVToRGB32Row_SSE(const uint8* y_buf,
                             const uint8* u_buf,
                             const uint8* v_buf,
                             uint8* rgb_buf,
-                            int width,
-                            int source_dx);
+                            ptrdiff_t width,
+                            ptrdiff_t source_dx);
 
 void ScaleYUVToRGB32Row_SSE2_X64(const uint8* y_buf,
                                  const uint8* u_buf,
                                  const uint8* v_buf,
                                  uint8* rgb_buf,
-                                 int width,
-                                 int source_dx);
+                                 ptrdiff_t width,
+                                 ptrdiff_t source_dx);
 
 void LinearScaleYUVToRGB32Row_C(const uint8* y_buf,
                                 const uint8* u_buf,
                                 const uint8* v_buf,
                                 uint8* rgb_buf,
-                                int width,
-                                int source_dx);
+                                ptrdiff_t width,
+                                ptrdiff_t source_dx);
 
 void LinearScaleYUVToRGB32RowWithRange_C(const uint8* y_buf,
                                          const uint8* u_buf,
                                          const uint8* v_buf,
                                          uint8* rgb_buf,
                                          int dest_width,
                                          int source_x,
                                          int source_dx);
 
 void LinearScaleYUVToRGB32Row_MMX(const uint8* y_buf,
                                   const uint8* u_buf,
                                   const uint8* v_buf,
                                   uint8* rgb_buf,
-                                  int width,
-                                  int source_dx);
+                                  ptrdiff_t width,
+                                  ptrdiff_t source_dx);
 
 void LinearScaleYUVToRGB32Row_SSE(const uint8* y_buf,
                                   const uint8* u_buf,
                                   const uint8* v_buf,
                                   uint8* rgb_buf,
-                                  int width,
-                                  int source_dx);
+                                  ptrdiff_t width,
+                                  ptrdiff_t source_dx);
 
 void LinearScaleYUVToRGB32Row_MMX_X64(const uint8* y_buf,
                                       const uint8* u_buf,
                                       const uint8* v_buf,
                                       uint8* rgb_buf,
-                                      int width,
-                                      int source_dx);
+                                      ptrdiff_t width,
+                                      ptrdiff_t source_dx);
 
 }  // extern "C"
 
 #endif  // MEDIA_BASE_SIMD_CONVERT_YUV_TO_RGB_H_