Chromium Code Reviews
Help | Chromium Project | Sign in
(56)

Issue 12211065: Add --enable-usermedia-screen-capturing in about:flags (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by Sergey Ulanov
Modified:
1 year, 2 months ago
Reviewers:
Wez
CC:
chromium-reviews_chromium.org
Visibility:
Public.

Description

Add --enable-usermedia-screen-capturing in about:flags

Then new flag allows to enable screen capture support for getUserMedia().

BUG=134249
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181405

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Lint Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +6 lines, -0 lines 0 comments ? errors Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments 1 errors Download
Trybot results:
Commit:

Messages

Total messages: 7
Sergey Ulanov
1 year, 2 months ago #1
Wez
LGTM https://chromiumcodereview.appspot.com/12211065/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/12211065/diff/1/chrome/app/generated_resources.grd#newcode7153 chrome/app/generated_resources.grd:7153: <message name="IDS_FLAGS_ENABLE_SCREEN_CAPTURING_NAME" desc="Name of the flag to enable ...
1 year, 2 months ago #2
Sergey Ulanov
https://chromiumcodereview.appspot.com/12211065/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/12211065/diff/1/chrome/app/generated_resources.grd#newcode7153 chrome/app/generated_resources.grd:7153: <message name="IDS_FLAGS_ENABLE_SCREEN_CAPTURING_NAME" desc="Name of the flag to enable screen ...
1 year, 2 months ago #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/12211065/2003
1 year, 2 months ago #4
Wez
lgtm https://chromiumcodereview.appspot.com/12211065/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/12211065/diff/1/chrome/app/generated_resources.grd#newcode7157 chrome/app/generated_resources.grd:7157: Allow the web pages to request screen capturing ...
1 year, 2 months ago #5
Sergey Ulanov
1 year, 2 months ago #6
Sergey Ulanov
1 year, 2 months ago #7
https://chromiumcodereview.appspot.com/12211065/diff/1/chrome/app/generated_r...
File chrome/app/generated_resources.grd (right):

https://chromiumcodereview.appspot.com/12211065/diff/1/chrome/app/generated_r...
chrome/app/generated_resources.grd:7157: Allow the web pages to request screen
capturing using getUserMedia() API.
On 2013/02/08 00:54:55, Wez wrote:
> On 2013/02/08 00:12:54, sergeyu wrote:
> > On 2013/02/07 22:20:08, Wez wrote:
> > > Suggest "Allow web pages to capture the screen contents via the
> getUserMedia()
> > > API."
> > 
> > Done, though with this wording some people may freak out - one may assume
that
> > access is given to any page automatically when this flag is enabled.
> 
> "Allow web pages to request access to the screen contents via the
> getUserMedia()" then?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434