chrome/browser/ui/webui/downloads_dom_handler.cc - Issue 12211049: Removing base::ThreadRestrictions::ScopedAllowIO from icon_manager_linux.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/downloads_dom_handler.cc

Issue 12211049: Removing base::ThreadRestrictions::ScopedAllowIO from icon_manager_linux.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes from review. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/icon_loader_chromeos.cc ('K') | « chrome/browser/ui/views/download/download_item_view.cc ('k') | chrome/browser/ui/webui/fileicon_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/downloads_dom_handler.cc

diff --git a/chrome/browser/ui/webui/downloads_dom_handler.cc b/chrome/browser/ui/webui/downloads_dom_handler.cc

index 209a9aba2b7a3d935091474db7d579f2b982ff32..5b94c09189d3ef6dd8da2a8a5c46c0bd71a2e7dc 100644

--- a/chrome/browser/ui/webui/downloads_dom_handler.cc

+++ b/chrome/browser/ui/webui/downloads_dom_handler.cc

@@ -342,7 +342,7 @@ void DownloadsDOMHandler::HandleDrag(const base::ListValue* args) {

// |web_contents| is only NULL in the test.

if (!file || !web_contents || !file->IsComplete())

return;

- gfx::Image* icon = g_browser_process->icon_manager()->LookupIcon(

+ gfx::Image* icon = g_browser_process->icon_manager()->LookupIconFromFilepath(

file->GetTargetFilePath(), IconLoader::NORMAL);

gfx::NativeView view = web_contents->GetNativeView();

{

« chrome/browser/icon_loader_chromeos.cc ('K') | « chrome/browser/ui/views/download/download_item_view.cc ('k') | chrome/browser/ui/webui/fileicon_source.cc » ('j') | no next file with comments »