chrome/browser/extensions/api/downloads/downloads_api.cc - Issue 12211049: Removing base::ThreadRestrictions::ScopedAllowIO from icon_manager_linux.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 12211049: Removing base::ThreadRestrictions::ScopedAllowIO from icon_manager_linux.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes from review. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/downloads/downloads_api.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc

index df50565ed39712137fdac97d7c83f43b2a48b1f7..35981c51e31ad778af2edb9b707e9e61f8fb3116 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc

@@ -969,7 +969,7 @@ bool DownloadsDragFunction::RunImpl() {

return false;

}

RecordApiFunctions(DOWNLOADS_FUNCTION_DRAG);

- gfx::Image* icon = g_browser_process->icon_manager()->LookupIcon(

+ gfx::Image* icon = g_browser_process->icon_manager()->LookupIconFromFilepath(

download_item->GetUserVerifiedFilePath(), IconLoader::NORMAL);

gfx::NativeView view = web_contents->GetNativeView();

{

« no previous file with comments | « no previous file | chrome/browser/icon_loader.h » ('j') | chrome/browser/icon_loader_android.cc » ('J')