chrome/browser/icon_loader_android.cc - Issue 12211049: Removing base::ThreadRestrictions::ScopedAllowIO from icon_manager_linux.cc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/icon_loader_android.cc

Issue 12211049: Removing base::ThreadRestrictions::ScopedAllowIO from icon_manager_linux.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes from review. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/logging.h"	5 #include "base/logging.h"

6 #include "chrome/browser/icon_loader.h"	6 #include "chrome/browser/icon_loader.h"

7	7

	8 IconGroupID IconLoader::ReadGroupIDFromFilepath(
	Robert Sesek 2013/03/08 18:41:26 Above static member functions, we generally put a Above static member functions, we generally put a "// static" comment. Same applies to all files.
	9 const base::FilePath& filepath) {

	10 NOTIMPLEMENTED();

	11 return 0;

	12 }

	13

8 void IconLoader::ReadIcon() {	14 void IconLoader::ReadIcon() {

9 NOTIMPLEMENTED();	15 NOTIMPLEMENTED();

10 }	16 }

OLD	NEW

« no previous file with comments | « chrome/browser/icon_loader.cc ('k') | chrome/browser/icon_loader_chromeos.cc » ('j') | chrome/browser/icon_loader_chromeos.cc » ('J')