Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 12211047: Implementing geolocation for the Android Webview (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed issues from reviews Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index 5a53dd1cb0f381f96c5b860ad44640bf7912af37..14d3694038cdd7c15840d5006305cc4545dd7918 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -23,20 +23,25 @@
namespace {
-class DummyAccessTokenStore : public content::AccessTokenStore {
+class AwAccessTokenStore : public content::AccessTokenStore {
public:
- DummyAccessTokenStore() { }
+ AwAccessTokenStore() { }
+ // content::AccessTokenStore implementation
virtual void LoadAccessTokens(
- const LoadAccessTokensCallbackType& request) OVERRIDE { }
-
- private:
- virtual ~DummyAccessTokenStore() { }
-
+ const LoadAccessTokensCallbackType& request) OVERRIDE {
+ AccessTokenStore::AccessTokenSet access_token_set;
+ // AccessTokenSet and net::URLRequestContextGetter not used on Android,
+ // but Run needs to be called to finish the geolocation setup.
+ request.Run(access_token_set, NULL);
+ }
virtual void SaveAccessToken(
const GURL& server_url, const string16& access_token) OVERRIDE { }
- DISALLOW_COPY_AND_ASSIGN(DummyAccessTokenStore);
+ private:
+ virtual ~AwAccessTokenStore() { }
+
+ DISALLOW_COPY_AND_ASSIGN(AwAccessTokenStore);
};
}
@@ -273,7 +278,7 @@ net::NetLog* AwContentBrowserClient::GetNetLog() {
content::AccessTokenStore* AwContentBrowserClient::CreateAccessTokenStore() {
// TODO(boliu): Implement as part of geolocation code.
- return new DummyAccessTokenStore();
+ return new AwAccessTokenStore();
}
bool AwContentBrowserClient::IsFastShutdownPossible() {

Powered by Google App Engine
This is Rietveld 408576698