Implementing geolocation for the Android Webview

android_webview/native/aw_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ANDROID_WEBVIEW_NATIVE_AW_CONTENTS_H_
 #define ANDROID_WEBVIEW_NATIVE_AW_CONTENTS_H_
 
 #include <jni.h>
+#include <list>
 #include <string>
+#include <utility>
 
 #include "android_webview/browser/find_helper.h"
 #include "android_webview/browser/icon_helper.h"
 #include "android_webview/browser/renderer_host/aw_render_view_host_ext.h"
 #include "android_webview/public/browser/draw_gl.h"
 #include "base/android/scoped_java_ref.h"
 #include "base/android/jni_helper.h"
+#include "base/callback_forward.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/public/browser/android/compositor.h"
 #include "content/public/browser/javascript_dialog_manager.h"
 #include "skia/ext/refptr.h"
 #include "third_party/skia/include/core/SkPicture.h"
 
 typedef void* EGLContext;
 class SkBitmap;
 class TabContents;
 
@@ skipping 93 matching lines @@
                            int scroll_x, int scroll_y);
   void FocusFirstNode(JNIEnv* env, jobject obj);
   base::android::ScopedJavaLocalRef<jobject> CapturePicture(JNIEnv* env,
                                                             jobject obj);
   void EnableOnNewPicture(JNIEnv* env,
                           jobject obj,
                           jboolean enabled,
                           jboolean invalidation_only);
 
   // Geolocation API support
-  void OnGeolocationShowPrompt(int render_process_id,
-                             int render_view_id,
-                             int bridge_id,
-                             const GURL& requesting_frame);
-  void OnGeolocationHidePrompt();
+  void OnGeolocationShowPrompt(const GURL& origin, base::Callback<void(bool)>);
+  void OnGeolocationHidePrompt(const GURL& origin);
+  void InvokeGeolocationCallback(
+      JNIEnv* env, jobject obj, jboolean value, jstring origin);
 
   // Find-in-page API and related methods.
   jint FindAllSync(JNIEnv* env, jobject obj, jstring search_string);
   void FindAllAsync(JNIEnv* env, jobject obj, jstring search_string);
   void FindNext(JNIEnv* env, jobject obj, jboolean forward);
   void ClearMatches(JNIEnv* env, jobject obj);
   void ClearCache(JNIEnv* env, jobject obj, jboolean include_disk_files);
 
   FindHelper* GetFindHelper();
 
@@ skipping 31 matching lines @@
   bool RenderPicture(SkCanvas* canvas);
 
   JavaObjectWeakGlobalRef java_ref_;
   scoped_ptr<content::WebContents> web_contents_;
   scoped_ptr<AwWebContentsDelegate> web_contents_delegate_;
   scoped_ptr<AwRenderViewHostExt> render_view_host_ext_;
   scoped_ptr<FindHelper> find_helper_;
   scoped_ptr<IconHelper> icon_helper_;
   scoped_ptr<content::WebContents> pending_contents_;
 
+  typedef std::pair<const GURL&, base::Callback<void(bool)> > OriginCallback;
+  std::list<OriginCallback> geolocation_callbacks_;

[boliu, 2013/02/06 20:29:54]

man this just begs for a native->java callback translation as Martin mentioned
in another patch.

I guess using list is a conscious decision since you don't expect more than a
few of these? sg

[Kristian Monsen, 2013/02/08 00:07:44]

The problem here is that these have to be stored native (I think), as the
callback can contain refcounted instances.

Used list since I expect there to be few, and the front to be removed. This is
the most expensive operation on a vector.

+
   // Compositor-specific state.
   scoped_ptr<content::Compositor> compositor_;
   scoped_refptr<cc::Layer> scissor_clip_layer_;
   scoped_refptr<cc::Layer> transform_layer_;
   scoped_refptr<cc::Layer> view_clip_layer_;
   gfx::Point hw_rendering_scroll_;
   gfx::Size view_size_;
   bool view_visible_;
   bool compositor_visible_;
   bool is_composite_pending_;
   OnNewPictureMode on_new_picture_mode_;
 
   // Used only for detecting Android View System context changes.
   // Not to be used between draw calls.
   EGLContext last_frame_context_;
 
   DISALLOW_COPY_AND_ASSIGN(AwContents);
 };
 
 bool RegisterAwContents(JNIEnv* env);
 
 }  // namespace android_webview
 
 #endif  // ANDROID_WEBVIEW_NATIVE_AW_CONTENTS_H_