chrome/browser/extensions/unpacked_installer.cc - Issue 12211029: Sanity tweaks to the extension blacklist: check all extensions at once on

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/unpacked_installer.cc

Issue 12211029: Sanity tweaks to the extension blacklist: check all extensions at once on (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ready for review Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service.cc ('K') | « chrome/browser/extensions/test_extension_service.cc ('k') | chrome/browser/extensions/updater/extension_updater_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/unpacked_installer.cc

diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc

index dceca42659794b78254eb8d6dd731df9e1586941..c93523352d4bf595e431cb3d4060c1780d89289f 100644

--- a/chrome/browser/extensions/unpacked_installer.cc

+++ b/chrome/browser/extensions/unpacked_installer.cc

@@ -71,7 +71,7 @@ void SimpleExtensionLoadPrompt::InstallUIProceed() {

if (service_weak_.get()) {

extensions::PermissionsUpdater perms_updater(service_weak_->profile());

perms_updater.GrantActivePermissions(extension_, false);

- service_weak_->OnExtensionInstalled(

+ service_weak_->InstallExtensionNow(

extension_,

syncer::StringOrdinal(),

false /* no requirement errors */,

@@ -264,10 +264,10 @@ void UnpackedInstaller::OnLoaded() {

PermissionsUpdater perms_updater(service_weak_->profile());

perms_updater.GrantActivePermissions(extension_, false);

- service_weak_->OnExtensionInstalled(extension_,

- syncer::StringOrdinal(),

- false /* no requirement errors */,

- false /* don't wait for idle */);

+ service_weak_->InstallExtensionNow(extension_,

+ syncer::StringOrdinal(),

+ false /* no requirement errors */,

+ false /* don't wait for idle */);

}

} // namespace extensions