Sanity tweaks to the extension blacklist: check all extensions at once on

chrome/browser/extensions/blacklist.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/blacklist.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
@@ skipping 163 matching lines @@
 
   // Constructing the SafeBrowsingClientImpl begins the process of asking
   // safebrowsing for the blacklisted extensions.
   new SafeBrowsingClientImpl(
       ids,
       base::Bind(&Blacklist::OnSafeBrowsingResponse, AsWeakPtr(),
                  pref_blacklisted_ids,
                  callback));
 }
 
+namespace {
+void IsNotEmpty(const Blacklist::IsBlacklistedCallback& callback,
+                const std::set<std::string>& set) {
+  callback.Run(set.empty());
+}
+}  // namespace

[Matt Perry, 2013/02/07 02:16:33]

nit: I think this might be against the style guide. I would move it up to the
top of the file with the rest of the anon namespace stuff.

[not at google - send to devlin, 2013/02/07 02:26:58]

Done.

+
+void Blacklist::IsBlacklisted(const std::string& extension_id,
+                              const IsBlacklistedCallback& callback) {
+  std::set<std::string> check;
+  check.insert(extension_id);
+  GetBlacklistedIDs(check, base::Bind(&IsNotEmpty, callback));
+}
+
 void Blacklist::SetFromUpdater(const std::vector<std::string>& ids,
                                const std::string& version) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   std::set<std::string> ids_as_set;
   for (std::vector<std::string>::const_iterator it = ids.begin();
        it != ids.end(); ++it) {
     if (Extension::IdIsValid(*it))
       ids_as_set.insert(*it);
     else
@@ skipping 63 matching lines @@
 }
 
 void Blacklist::Observe(int type,
                         const content::NotificationSource& source,
                         const content::NotificationDetails& details) {
   DCHECK_EQ(chrome::NOTIFICATION_SAFE_BROWSING_UPDATE_COMPLETE, type);
   FOR_EACH_OBSERVER(Observer, observers_, OnBlacklistUpdated());
 }
 
 }  // namespace extensions