Sanity tweaks to the extension blacklist: check all extensions at once on

chrome/browser/extensions/crx_installer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 112 matching lines @@
   void set_expected_version(const Version& val) {
     expected_version_.reset(new Version(val));
   }
 
   bool delete_source() const { return delete_source_; }
   void set_delete_source(bool val) { delete_source_ = val; }
 
   bool allow_silent_install() const { return allow_silent_install_; }
   void set_allow_silent_install(bool val) { allow_silent_install_ = val; }
 
+  void set_bypass_blacklist_for_test(bool val) {
+    bypass_blacklist_for_test_ = val;
+  }
+
   bool is_gallery_install() const {
     return (creation_flags_ & Extension::FROM_WEBSTORE) > 0;
   }
   void set_is_gallery_install(bool val) {
     if (val)
       creation_flags_ |= Extension::FROM_WEBSTORE;
     else
       creation_flags_ &= ~Extension::FROM_WEBSTORE;
   }
 
@@ skipping 67 matching lines @@
   // should complete.
   CrxInstallerError AllowInstall(const Extension* extension);
 
   // SandboxedUnpackerClient
   virtual void OnUnpackFailure(const string16& error_message) OVERRIDE;
   virtual void OnUnpackSuccess(const base::FilePath& temp_dir,
                                const base::FilePath& extension_dir,
                                const base::DictionaryValue* original_manifest,
                                const Extension* extension) OVERRIDE;
 
-  // Returns true if we can skip confirmation because the install was
-  // whitelisted.
-  bool CanSkipConfirmation();
-
   // Called on the UI thread to start the requirements check on the extension.
   void CheckRequirements();
 
   // Runs on the UI thread. Callback from RequirementsChecker.
   void OnRequirementsChecked(std::vector<std::string> requirement_errors);
 
   // Runs on the UI thread. Confirms with the user (via ExtensionInstallPrompt)
   // that it is OK to install this extension.
   void ConfirmInstall();
 
   // Runs on File thread. Install the unpacked extension into the profile and
   // notify the frontend.
   void CompleteInstall();
 
   // Result reporting.
   void ReportFailureFromFileThread(const CrxInstallerError& error);
   void ReportFailureFromUIThread(const CrxInstallerError& error);
   void ReportSuccessFromFileThread();
   void ReportSuccessFromUIThread();
-  void NotifyCrxInstallComplete(const Extension* extension);
+  void HandleIsBlacklistedResponse(const base::Closure& on_success,
+                                   bool success);
+  void NotifyCrxInstallComplete(bool success);
 
   // Deletes temporary directory and crx file if needed.
   void CleanupTempFiles();
 
   // Creates sequenced task runner for extension install file I/O operations.
   scoped_refptr<base::SequencedTaskRunner> CreateSequencedTaskRunner();
 
   // The file we're installing.
   base::FilePath source_file_;
 
@@ skipping 82 matching lines @@
   // The root of the unpacked extension directory. This is a subdirectory of
   // temp_dir_, so we don't have to delete it explicitly.
   base::FilePath unpacked_extension_root_;
 
   // True when the CRX being installed was just downloaded.
   // Used to trigger extra checks before installing.
   bool apps_require_extension_mime_type_;
 
   // Allows for the possibility of a normal install (one in which a |client|
   // is provided in the ctor) to procede without showing the permissions prompt
-  // dialog. Note that this will only take place if |allow_silent_install_|
-  // is true AND the unpacked id of the extension is whitelisted with
-  // SetWhitelistedInstallId().
+  // dialog.
   bool allow_silent_install_;
 
+  // Allows for bypassing the blacklist check. Only use for tests.
+  bool bypass_blacklist_for_test_;
+
   // The value of the content type header sent with the CRX.
   // Ignorred unless |require_extension_mime_type_| is true.
   std::string original_mime_type_;
 
   // What caused this install?  Used only for histograms that report
   // on failure rates, broken down by the cause of the install.
   extension_misc::CrxInstallCause install_cause_;
 
   // Creation flags to use for the extension.  These flags will be used
   // when calling Extenion::Create() by the crx installer.
@@ skipping 28 matching lines @@
 
   // Used to show the install dialog.
   ExtensionInstallPrompt::ShowDialogCallback show_dialog_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_