Sanity tweaks to the extension blacklist: check all extensions at once on

chrome/browser/extensions/crx_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/crx_installer.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/lazy_instance.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/sequenced_task_runner.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
+#include "base/threading/sequenced_worker_pool.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/time.h"
-#include "base/threading/sequenced_worker_pool.h"
 #include "base/utf_string_conversions.h"
 #include "base/version.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/convert_user_script.h"
 #include "chrome/browser/extensions/convert_web_app.h"
 #include "chrome/browser/extensions/extension_error_reporter.h"
 #include "chrome/browser/extensions/extension_install_ui.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/management_policy.h"
@@ skipping 60 matching lines @@
       install_source_(Manifest::INTERNAL),
       approved_(false),
       extensions_enabled_(frontend_weak->extensions_enabled()),
       delete_source_(false),
       create_app_shortcut_(false),
       frontend_weak_(frontend_weak),
       profile_(frontend_weak->profile()),
       client_(client),
       apps_require_extension_mime_type_(false),
       allow_silent_install_(false),
+      bypass_blacklist_for_test_(false),
       install_cause_(extension_misc::INSTALL_CAUSE_UNSET),
       creation_flags_(Extension::NO_FLAGS),
       off_store_install_allow_reason_(OffStoreInstallDisallowed),
       did_handle_successfully_(true),
       record_oauth2_grant_(false),
       error_on_unsupported_requirements_(false),
       requirements_checker_(new extensions::RequirementsChecker()),
       has_requirement_errors_(false),
       install_wait_for_idle_(true) {
   installer_task_runner_ = frontend_weak->GetFileTaskRunner();
@@ skipping 367 matching lines @@
   ExtensionService::RecordPermissionMessagesHistogram(
       extension_, histogram_name.c_str());
 
   // Kill the theme loading bubble.
   content::NotificationService* service =
       content::NotificationService::current();
   service->Notify(chrome::NOTIFICATION_NO_THEME_DETECTED,
                   content::Source<CrxInstaller>(this),
                   content::NotificationService::NoDetails());
 
-  NotifyCrxInstallComplete(NULL);
+  NotifyCrxInstallComplete(false);
 
   Release();  // balanced in ConfirmInstall().
 
   // We're done. Since we don't post any more tasks to ourself, our ref count
   // should go to zero and we die. The destructor will clean up the temp dir.
 }
 
 void CrxInstaller::CompleteInstall() {
   DCHECK(installer_task_runner_->RunsTasksOnCurrentThread());
 
@@ skipping 40 matching lines @@
   std::string error;
   extension_ = extension_file_util::LoadExtension(
       version_dir,
       install_source_,
       extension_->creation_flags() | Extension::REQUIRE_KEY,
       &error);
 
   if (extension_) {
     ReportSuccessFromFileThread();
   } else {
-    LOG(ERROR) << error << " " << extension_id << " " << download_url_.spec();
+    LOG(ERROR) << error << " " << extension_id << " " << download_url_;
     ReportFailureFromFileThread(CrxInstallerError(UTF8ToUTF16(error)));
   }
 
 }
 
 void CrxInstaller::ReportFailureFromFileThread(const CrxInstallerError& error) {
   DCHECK(installer_task_runner_->RunsTasksOnCurrentThread());
   if (!BrowserThread::PostTask(
           BrowserThread::UI, FROM_HERE,
           base::Bind(&CrxInstaller::ReportFailureFromUIThread, this, error))) {
@@ skipping 14 matching lines @@
   // see errors get reported via this interface.
   //
   // TODO(aa): Need to go through unit tests and clean them up too, probably get
   // rid of this line.
   ExtensionErrorReporter::GetInstance()->ReportError(
       error.message(), false);  // quiet
 
   if (client_)
     client_->OnInstallFailure(error);
 
-  NotifyCrxInstallComplete(NULL);
+  NotifyCrxInstallComplete(false);
 
   // Delete temporary files.
   CleanupTempFiles();
 }
 
 void CrxInstaller::ReportSuccessFromFileThread() {
   DCHECK(installer_task_runner_->RunsTasksOnCurrentThread());
 
   // Tracking number of extensions installed by users
   if (install_cause() == extension_misc::INSTALL_CAUSE_USER_DOWNLOAD)
@@ skipping 23 matching lines @@
     record_oauth2_grant_ = client_->record_oauth2_grant();
 
   // We update the extension's granted permissions if the user already approved
   // the install (client_ is non NULL), or we are allowed to install this
   // silently.
   if (client_ || allow_silent_install_) {
     PermissionsUpdater perms_updater(profile());
     perms_updater.GrantActivePermissions(extension_, record_oauth2_grant_);
   }
 
-  // Tell the frontend about the installation and hand off ownership of
-  // extension_ to it.
-  frontend_weak_->OnExtensionInstalled(extension_,
-                                       page_ordinal_,
-                                       has_requirement_errors_,
-                                       install_wait_for_idle_);
-
-  NotifyCrxInstallComplete(extension_.get());
-
-  extension_ = NULL;
-
-  // We're done. We don't post any more tasks to ourselves so we are deleted
-  // soon.
+  // Install the extension if it's not blacklisted, but notify either way.
+  base::Closure on_success =
+      base::Bind(&ExtensionService::OnExtensionInstalled,
+                 frontend_weak_,
+                 extension_,
+                 page_ordinal_,
+                 has_requirement_errors_,
+                 install_wait_for_idle_);
+  if (bypass_blacklist_for_test_) {
+    HandleIsBlacklistedResponse(on_success, false);
+  } else {
+    ExtensionSystem::Get(profile_)->blacklist()->IsBlacklisted(
+        extension_->id(),
+        base::Bind(&CrxInstaller::HandleIsBlacklistedResponse,
+                   this,
+                   on_success));
+  }
 }
 
-void CrxInstaller::NotifyCrxInstallComplete(const Extension* extension) {
+void CrxInstaller::HandleIsBlacklistedResponse(
+    const base::Closure& on_success,
+    bool is_blacklisted) {
+  if (is_blacklisted) {
+    string16 error =
+        l10n_util::GetStringFUTF16(IDS_EXTENSION_IS_BLACKLISTED,
+                                   UTF8ToUTF16(extension_->name()));
+    make_scoped_ptr(ExtensionInstallUI::Create(profile()))->OnInstallFailure(
+        extensions::CrxInstallerError(error));
+    // Show error via reporter to make tests happy.
+    ExtensionErrorReporter::GetInstance()->ReportError(error, false);  // quiet
+  } else {
+    on_success.Run();
+  }
+  NotifyCrxInstallComplete(!is_blacklisted);
+}
+
+void CrxInstaller::NotifyCrxInstallComplete(bool success) {
   // Some users (such as the download shelf) need to know when a
   // CRXInstaller is done.  Listening for the EXTENSION_* events
   // is problematic because they don't know anything about the
   // extension before it is unpacked, so they cannot filter based
   // on the extension.
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_CRX_INSTALLER_DONE,
       content::Source<CrxInstaller>(this),
-      content::Details<const Extension>(extension));
+      content::Details<const Extension>(success ? extension_.get() : NULL));
+
+  // We're done. We don't post any more tasks to ourselves so we are deleted
+  // soon.
+  extension_ = NULL;
 }
 
 void CrxInstaller::CleanupTempFiles() {
   if (!installer_task_runner_->RunsTasksOnCurrentThread()) {
     if (!installer_task_runner_->PostTask(
             FROM_HERE,
             base::Bind(&CrxInstaller::CleanupTempFiles, this))) {
       NOTREACHED();
     }
     return;
   }
 
   // Delete the temp directory and crx file as necessary.
   if (!temp_dir_.value().empty()) {
     extension_file_util::DeleteFile(temp_dir_, true);
     temp_dir_ = base::FilePath();
   }
 
   if (delete_source_ && !source_file_.value().empty()) {
     extension_file_util::DeleteFile(source_file_, false);
     source_file_ = base::FilePath();
   }
 }
 
 }  // namespace extensions