sdk/lib/_internal/compiler/implementation/ssa/codegen.dart - Issue 12211012: Revert "Implement substitution for type variables."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 12211012: Revert "Implement substitution for type variables." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

index 5c663a67dbf04b91001fdbcf7ec7541e159916fe..81641181999efaadb306102e2660daa81908fb31 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

@@ -2363,13 +2363,15 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {

checkType(input, type);

attachLocationToLast(node);

}

- if (node.hasArgumentsCheck()) {

+ if (node.hasArgumentChecks()) {

InterfaceType interfaceType = type;

ClassElement cls = type.element;

Link<DartType> arguments = interfaceType.typeArguments;

js.Expression result = pop();

- use(node.checkCall);

- result = new js.Binary('&&', result, pop());

+ for (int i = 0; i < node.checkCount; i++) {

+ use(node.getCheck(i));

+ result = new js.Binary('&&', result, pop());

+ }

push(result, node);

}

if (node.nullOk) {