Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 12211005: fix build with enable_web_intents=0 on chromeos (Closed)

Created:
7 years, 10 months ago by Nico
Modified:
7 years, 10 months ago
Reviewers:
satorux1, tbarzic
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

fix build with enable_web_intents=0 on chromeos enable_web_intents is still set to 1, so this has no observable effect. BUG=173194 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180654

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 5 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
It looks like you're an owner in this directory. Can you take a look? It's ...
7 years, 10 months ago (2013-02-05 03:22:45 UTC) #1
satorux1
I think we can just remove the code rather than #ifdef out. tbarzi@, what do ...
7 years, 10 months ago (2013-02-05 04:39:32 UTC) #2
satorux1
Sending LGTM for now. We can remove the code at a later time.
7 years, 10 months ago (2013-02-05 04:40:49 UTC) #3
Nico
On 2013/02/05 04:39:32, satorux1 wrote: > I think we can just remove the code rather ...
7 years, 10 months ago (2013-02-05 04:41:23 UTC) #4
Nico
On Mon, Feb 4, 2013 at 8:40 PM, <satorux@chromium.org> wrote: > Sending LGTM for now. ...
7 years, 10 months ago (2013-02-05 04:41:40 UTC) #5
tbarzic
deleting in a follow-up sound good to me.
7 years, 10 months ago (2013-02-05 04:47:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/12211005/1003
7 years, 10 months ago (2013-02-05 04:50:34 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-05 08:41:22 UTC) #8
Message was sent while issue was closed.
Change committed as 180654

Powered by Google App Engine
This is Rietveld 408576698