Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1221093003: Allow 'currentcolor' for -webkit-tap-highlight-color in non-quirks mode (Closed)

Created:
5 years, 5 months ago by fs
Modified:
5 years, 5 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Allow 'currentcolor' for -webkit-tap-highlight-color in non-quirks mode Seems like a fairly artificial limit (== oversight) since it will be resolved during style resolution already (for the quirks mode case). This moves this property one step closer to being just a "plain" <color>. BUG=505410 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 5 months ago (2015-07-02 21:14:57 UTC) #2
Timothy Loh
On 2015/07/02 21:14:57, fs wrote: lgtm
5 years, 5 months ago (2015-07-03 01:48:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221093003/1
5 years, 5 months ago (2015-07-03 07:36:28 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 07:39:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198265

Powered by Google App Engine
This is Rietveld 408576698