Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: content/browser/frame_host/frame_tree_node.cc

Issue 1221083007: PlzNavigate: remove extraneous DidStartLoading IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed issue with navigation in speculative RFH Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/frame_tree_node.cc
diff --git a/content/browser/frame_host/frame_tree_node.cc b/content/browser/frame_host/frame_tree_node.cc
index 409a2a84932d6b0330cadc30c3eaa7e9121a972a..a38506ced1347355ef22c2822d59e6a3c6a6c22b 100644
--- a/content/browser/frame_host/frame_tree_node.cc
+++ b/content/browser/frame_host/frame_tree_node.cc
@@ -235,6 +235,13 @@ bool FrameTreeNode::IsLoading() const {
switches::kEnableBrowserSideNavigation)) {
if (navigation_request_)
return true;
+
+ // Check if a navigation is about ot commit in the speculative
Fabrice (no longer in Chrome) 2015/07/07 15:16:35 nit: s/ot/to/
nasko 2015/07/07 15:18:57 nit: Does it really matter whether it is about to
clamy 2015/07/07 15:23:58 Well it should only tell us that it is loading whe
+ // RenderFrameHost.
+ RenderFrameHostImpl* speculative_frame_host =
+ render_manager_.speculative_frame_host();
+ if (speculative_frame_host && speculative_frame_host->is_loading())
+ return true;
} else {
if (pending_frame_host && pending_frame_host->is_loading())
return true;
« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698