Issue 1221033006: Teach Stocks.apk how to load a skyx bundle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1221033006: Teach Stocks.apk how to load a skyx bundle (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
eseidel1

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jackson_old, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Teach Stocks.apk how to load a skyx bundle This CL teaches Stocks.apk how to start from a skyx bundle name |app.skyx| in the APK's asset collection. Stocks.apk still actually starts from |snapshot_blob.bin| because we can't yet produce skyx files as part of the build process. TBR=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/751835fa5c766162f0cc9a2332c9382a5b734eca

Patch Set 1 #

Patch Set 2 : reupload #

Patch Set 3 : again #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -12 lines)			Patch
M	sky/services/engine/sky_engine.mojom	View	2 chunks	+1 line, -1 line	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/SkyActivity.java	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/SkyApplication.java	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	sky/shell/ui/engine.h	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	sky/shell/ui/engine.cc	View	5 chunks	+27 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 5 months ago (2015-07-02 20:10:01 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
751835fa5c766162f0cc9a2332c9382a5b734eca (presubmit successful).

Expand Messages | Collapse Messages