Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1221033002: Add proxy_config component (Closed)

Created:
5 years, 5 months ago by stevenjb
Modified:
5 years, 5 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, michaelpg+watch-options_chromium.org, dzhioev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add proxy_config component This CL moves proxy_config_dictionary and proxy_prefs to src/components/proxy_config so that they can be used in src/chromeos/network/onc for ONC translation. BUG=470445 TBR=various for moving include files Committed: https://crrev.com/b237e2aea0d2c50b19e0e6109a3d76b282630572 Cr-Commit-Position: refs/heads/master@{#337257}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Update copyrights #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -567 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/net/onc_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/onc_utils.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/proxy_config_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/proxy_config_service_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui_proxy_config.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/ui_proxy_config.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/pref_proxy_config_tracker_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/proxy_policy_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/proxy_policy_handler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/command_line_pref_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/prefs/proxy_config_dictionary.h View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/prefs/proxy_config_dictionary.cc View 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/browser/prefs/proxy_config_dictionary_unittest.cc View 1 chunk +0 lines, -86 lines 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/prefs/proxy_prefs.h View 1 chunk +0 lines, -70 lines 0 comments Download
D chrome/browser/prefs/proxy_prefs.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/prefs/proxy_prefs_unittest.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_state_informer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/preferences_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 5 chunks +11 lines, -14 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +3 lines, -5 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/components.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 3 chunks +6 lines, -0 lines 0 comments Download
A + components/proxy_config.gypi View 1 1 chunk +8 lines, -7 lines 0 comments Download
A components/proxy_config/BUILD.gn View 1 1 chunk +20 lines, -0 lines 0 comments Download
A + components/proxy_config/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
A + components/proxy_config/proxy_config_dictionary.h View 3 chunks +6 lines, -5 lines 0 comments Download
A + components/proxy_config/proxy_config_dictionary.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/proxy_config/proxy_config_dictionary_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A components/proxy_config/proxy_config_export.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A + components/proxy_config/proxy_prefs.h View 3 chunks +17 lines, -14 lines 0 comments Download
A + components/proxy_config/proxy_prefs.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/proxy_config/proxy_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
stevenjb
5 years, 5 months ago (2015-07-01 23:31:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221033002/1
5 years, 5 months ago (2015-07-01 23:34:21 UTC) #4
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 5 months ago (2015-07-01 23:40:01 UTC) #6
pneubeck (no reviews)
Mattias, ptal at components/proxy_config/OWNERS lgtm https://codereview.chromium.org/1221033002/diff/1/components/proxy_config.gypi File components/proxy_config.gypi (right): https://codereview.chromium.org/1221033002/diff/1/components/proxy_config.gypi#newcode1 components/proxy_config.gypi:1: # Copyright 2013 The ...
5 years, 5 months ago (2015-07-02 08:13:49 UTC) #7
stevenjb
https://codereview.chromium.org/1221033002/diff/1/components/proxy_config.gypi File components/proxy_config.gypi (right): https://codereview.chromium.org/1221033002/diff/1/components/proxy_config.gypi#newcode1 components/proxy_config.gypi:1: # Copyright 2013 The Chromium Authors. All rights reserved. ...
5 years, 5 months ago (2015-07-02 16:00:09 UTC) #8
Mattias Nissler (ping if slow)
LGTM
5 years, 5 months ago (2015-07-02 16:07:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221033002/20001
5 years, 5 months ago (2015-07-02 16:10:04 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/26761)
5 years, 5 months ago (2015-07-02 16:33:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1221033002/20001
5 years, 5 months ago (2015-07-02 21:47:37 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-02 22:02:19 UTC) #17
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 22:03:26 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b237e2aea0d2c50b19e0e6109a3d76b282630572
Cr-Commit-Position: refs/heads/master@{#337257}

Powered by Google App Engine
This is Rietveld 408576698