Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 12210150: more localization in autofill dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index 98ab9b1e525ff6e1ae54dac064d183887875a280..0e6755fa774eb4415a71df1b68d8d0d6e5e28e98 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -248,11 +248,6 @@ string16 AutofillDialogControllerImpl::UseBillingForShippingText() const {
IDS_AUTOFILL_DIALOG_USE_BILLING_FOR_SHIPPING);
}
-string16 AutofillDialogControllerImpl::WalletOptionText() const {
- // TODO(estade): real strings and l10n.
- return string16(ASCIIToUTF16("I love lamp."));
-}
-
string16 AutofillDialogControllerImpl::CancelButtonText() const {
return l10n_util::GetStringUTF16(IDS_CANCEL);
}
@@ -852,8 +847,6 @@ void AutofillDialogControllerImpl::GenerateSuggestionsModels() {
for (size_t i = 0; i < cards.size(); ++i) {
suggested_cc_.AddKeyedItem(cards[i]->guid(), cards[i]->Label());
}
- // TODO(estade): real strings and i18n.
- suggested_cc_.AddKeyedItem("", ASCIIToUTF16("Enter new card"));
const std::vector<AutofillProfile*>& profiles = manager->GetProfiles();
const std::string app_locale = AutofillCountry::ApplicationLocale();
@@ -875,10 +868,18 @@ void AutofillDialogControllerImpl::GenerateSuggestionsModels() {
suggested_shipping_.AddKeyedItem(profiles[i]->guid(), profiles[i]->Label());
}
- // TODO(estade): real strings and i18n.
- suggested_billing_.AddKeyedItem("", ASCIIToUTF16("Enter new billing"));
- suggested_email_.AddKeyedItem("", ASCIIToUTF16("Enter new email"));
- suggested_shipping_.AddKeyedItem("", ASCIIToUTF16("Enter new shipping"));
+ suggested_email_.AddKeyedItem(
+ std::string(),
+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_ADD_EMAIL_ADDRESS));
+ suggested_cc_.AddKeyedItem(
+ std::string(),
+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_ADD_CREDIT_CARD));
+ suggested_billing_.AddKeyedItem(
+ std::string(),
+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_ADD_BILLING_ADDRESS));
+ suggested_shipping_.AddKeyedItem(
+ std::string(),
+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_ADD_SHIPPING_ADDRESS));
}
bool AutofillDialogControllerImpl::IsCompleteProfile(
« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698