suppress memory leak from GtkThemeService::GtkThemeService

suppress memory leak from GtkThemeService::GtkThemeService 
TBR=petewil@chromium.org,MHX348@motorola.com 
BUG=175744
TEST=waterfall.sh

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181995

[petewil, 2013-02-12 17:37:32]

I'm happy to review this, but I don't understand what the change is doing.
 Is this just telling the test framework to ignore the memory leak?


On Tue, Feb 12, 2013 at 9:33 AM, <zhaoqin@google.com> wrote:

> Reviewers: Pete Williamson, mhx348_motorola.com,
>
> Description:
> suppress memory leak from GtkThemeService::**GtkThemeService
> TBR=petewil@chromium.org,MHX34**8@motorola.com <MHX348@motorola.com>
> BUG=175744
> TEST=waterfall.sh
>
>
> Please review this at
https://codereview.chromium.**org/12210146/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M tools/heapcheck/suppressions.**txt
>
>
> Index: tools/heapcheck/suppressions.**txt
> diff --git a/tools/heapcheck/**suppressions.txt b/tools/heapcheck/**
> suppressions.txt
> index 0d50e28416022b124cd4df773c4b66**be13af1dc9..**
> adcc03c0bc11df2372e27abc969056**fcbbbb7a42 100644
> --- a/tools/heapcheck/**suppressions.txt
> +++ b/tools/heapcheck/**suppressions.txt
> @@ -1790,3 +1790,18 @@
>     fun:::StartExplicitSync
>     fun:OneClickSigninHelper::**DidStopLoading
>  }
> +{
> +   bug_175744
> +   Heapcheck:Leak
> +   ...
> +   fun:GtkThemeService::**GtkThemeService
> +   fun:ThemeServiceFactory::**BuildServiceInstanceFor
> +   fun:**ProfileKeyedServiceFactory::**GetServiceForProfile
> +   fun:**ProfileKeyedServiceFactory::**CreateServiceNow
> +   fun:ProfileDependencyManager::**CreateProfileServices
> +   fun:TestingProfile::Init
> +   fun:TestingProfile::**TestingProfile
> +   fun:**OAuth2RevocationFetcherTest::**OAuth2RevocationFetcherTest
> +   fun:**OAuth2RevocationFetcherTest_**RequestFailure_Test::**
> OAuth2RevocationFetcherTest_**RequestFailure_Test
> +   fun:testing::internal::**TestFactoryImpl::CreateTest
> +}
>
>
>

[Joe Thomas, 2013-02-12 17:51:37]

https://codereview.chromium.org/12210146/diff/1/tools/heapcheck/suppressions.txt
File tools/heapcheck/suppressions.txt (right):

https://codereview.chromium.org/12210146/diff/1/tools/heapcheck/suppressions....
tools/heapcheck/suppressions.txt:1804:
fun:OAuth2RevocationFetcherTest::OAuth2RevocationFetcherTest
Is the leak happening only with OAuth2RevocationFetcherTest? There are other
tests also which creates TestingProfile object.

[zhaoqin, 2013-02-12 18:44:49]

only OAuth2RevocationFetcherTest cause the leak, but I did not see any CLs
related to OAuth2, so find most possible CLs and notify them.


On Tue, Feb 12, 2013 at 12:51 PM, <MHX348@motorola.com> wrote:

>
> https://codereview.chromium.**org/12210146/diff/1/tools/**
>
heapcheck/suppressions.txt<https://codereview.chromium.org/12210146/diff/1/tools/heapcheck/suppressions.txt>
> File tools/heapcheck/suppressions.**txt (right):
>
> https://codereview.chromium.**org/12210146/diff/1/tools/**
>
heapcheck/suppressions.txt#**newcode1804<https://codereview.chromium.org/12210146/diff/1/tools/heapcheck/suppressions.txt#newcode1804>
> tools/heapcheck/suppressions.**txt:1804:
> fun:**OAuth2RevocationFetcherTest::**OAuth2RevocationFetcherTest
> Is the leak happening only with OAuth2RevocationFetcherTest? There are
> other tests also which creates TestingProfile object.
>
>
https://codereview.chromium.**org/12210146/<https://codereview.chromium.org/1...
>



-- 
Interested in Yoga? Be careful of *The Yoga
Cult*<http://www.sabrinaerdely.com/docs/YogaCult.pdf>
 or *The Scary Yoga
Obsession<http://www.glamour.com/magazine/2009/12/the-scary-yoga-obsession?printable=true>
.*
More information from Lorie Anderson<http://www.selectsmart.com/ilchilee.html>
 and *Rick Ross* <http://www.rickross.com/groups/dti.html>.