sdk/lib/_internal/compiler/implementation/world.dart - Issue 12210142: Implement is-checks against type variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/world.dart

Issue 12210142: Implement is-checks against type variables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix computation of classes that need rti. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/world.dart

diff --git a/sdk/lib/_internal/compiler/implementation/world.dart b/sdk/lib/_internal/compiler/implementation/world.dart

index 271629bf64132666df45a3b3aba08074886ca86e..6fdf57f51eaccd7f0f0d4093631a4615b0d0d0f5 100644

--- a/sdk/lib/_internal/compiler/implementation/world.dart

+++ b/sdk/lib/_internal/compiler/implementation/world.dart

@@ -60,7 +60,6 @@ class World {

// (3) subclasses of (2) and (3).

void potentiallyAddForRti(ClassElement cls) {

- if (cls.typeVariables.isEmpty) return;

if (classesNeedingRti.contains(cls)) return;

classesNeedingRti.add(cls);

@@ -85,6 +84,9 @@ class World {

if (!itf.isRaw) {

potentiallyAddForRti(itf.element);

}

+ } else if (type is TypeVariableType) {

+ TypeVariableElement variable = type.element;

+ potentiallyAddForRti(variable.enclosingElement);

}

});

}